[Pkg-kbd-devel] Bug#766240: kbd: cosmetic updates to showkey.c

[Nicolas Boulenguez]

Package: kbd
Version: 1.15.5-1
Severity: wishlist
Tags: upstream patch

Hello.

In src/showkey.c, when the keyboard mode is not K_XLATE, a warning is
displayed that showkey may fail under X.  I suggest to consider
K_UNICODE as normal as K_XLATE, or even remove this warning since
getfd() will exit() if X is detected.

Later, the code calls signal() for every known signal. This fails with
SIGKILL and SIGSTOP, but this has never been detected because the
return value is not tested.  I suggest to update the signal list from
signal(7), store it in an array for readability, and check errors.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: showkey.c.diff
Type: text/x-diff
Size: 2486 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-kbd-devel/attachments/20141021/974ee270/attachment.diff>