[Pkg-kbd-devel] Bug#796583: Please review pkg-kbd changes for kbd.init deprecation

[Michael Schutte]

Hi Andreas,

On Mon, Jan 04, 2016 at 11:49:58AM +0100, Andreas Henriksson wrote:
> Happy new year!
> 
> Just writing you this short mail to say that I'd be very happy if
> you by any chance have time to review the changes I've pushed
> to pkg-kbd git repo. From the historical traces in the bts I've
> found it seems like you and me had pretty similar ideas on how
> to handle the deprecation of the kbd init script. If you could
> check that my current implementation aligns with your vision
> and ack it before I upload that would be much appreciated!
> (I'm a bit trigger happy on the upload part as always, so if
> you want me to give you more time feel free to just tell me
> to hold off so I know.)

A happy new year to you as well!

I'd say your changes look exactly like what I had in mind.  I was
briefly unsure if the rm_conffile invocations should additionally be
conditioned on unchangedness of /etc/init.d/kbd to serve even the
unlikely minority of people who have modified the initscript, but not
the configuration in /etc/kbd.  But since the default configuration in
that directory is very minimal and the initscript deals gracefully with
its nonexistence, the way you've done it is probably ideal.  The
announcement in NEWS is also a good idea.

Thank you for your work once again!  I hope I'm not missing anything,
but it looks ready for an upload to me.

Cheers,
Michael