[Pkg-kde-extras] Re: knemo pkging

[Achim Bohnet]

On Friday 09 September 2005 20:14, you wrote:
> Achim Bohnet schrieb:
> > Hi,
> > knemo upload was rejected shortly before the C++ trans started
> > in sid.  I had another look at it tonight but run out of time.
> > I'll have no time to work on it at least until Friday night.
> > 
> > So Michael, here's your change to jump into the KDE Extras Team
> > pkging effort ;)  If you have time feel free to work on/finish in
> > in the next days.  If you hang around on freenode IRC ping
> > me my nick is allee.
> 
> Hi everybody,
> 
> I'm new to this list and also haven't used alioth before. I'm currently
> in the NM process and already maintain several packages. I have
> experience in debhelper/cdbs/svn-buildpackage which I use for my own

cdbs and svn-buildpackage is what we use in pkg-kde/kde-extras
on alioth.  With additional dephelper knowledge you're even
'overqualified' ;) *duck*

> packages already. I got in contact with Achim as I wanted to know about
> the current status of knemo. So he directed me to this list.
> 
> > Current debian/ dir version is found in alioth svn.  See
> > http://svn.debian.org/wsvn/pkg-kde/kde-extras/knemo/trunk/?rev=0&sc=0
> > The orig tar file is at http://www.mpe.mpg.de/~ach/debian/sid/
> > 
> > If interested you're welcome on list
> > http://lists.alioth.debian.org/mailman/listinfo/pkg-kde-extras
> >  (haven't check subscribers list. it's (too) late already)
> 
> The package builds fine on my Sid system and seems to be ready for an
> initial release. There are two issues I noticed and like to discuss with
> you:
> 1.) I always add autotools-dev to my build dependencies list so that I
> get the newest config.(sub|guess). cdbs takes care for the rest.
> I noticed that knemo and most of the other packages in kde-extras don't
> do this. Do you normally discourage this and if so, why?

Well, I just learn something new ;)  I often saw the config.* copy
and think it's a good thing. Obviously I never noticed that it did
not happend in my pbuilder runs.

As a minimalist one may say: if it works without.  If one wants to
play save: include autotools-dev.  So commited:

+  * build-dep: add autotools-dev so recent config.guess config.sub are
+    used (Thx Michael Biebl)


Side note: With cdbs in sarge/hoary has a cleanup bug so the diff
of config.sub,guess ends up in the diff after the second run.

> 2.) knemo uses the deprecated /usr/share/applnk path for its desktop
> file. Achim fixed this by moving the desktop file to the new location
> during the install stage in debian/rules.
> I took another approach and patched the Makefile.(am|in) files using the
>  the simple-patchsys rule. The resulting diff.gz is attached.
> The advantage of this approach is that I can easily send this patches
> upstream (which I already did btw.). What's the common practice, do you
> advise against patching Makefile.(am|in)?

I like my approach because it's easier to handle if upstream supports
KDE 3.1 and therefore has to use applnk (e.g. digikam)
I like small diffs so I usually do trival stuff in rules and report
upstream instead of patching Makefile.*.

Hole thing is matter of taste.  Both methods are okay IMO.
Let's stick with current version.  With 0.3.2 we get rid of
it automaticly ;)

Btw. only moving file is often not enough, one also needs to check the
contents of the desktop file.  knemos misses e.g. GenericName and
stricly speaking version too.  Comments 'need' rephrase too.


> > FYI: On kubuntu hoary with KDE 3.4.2 and knetworkconf I got these
> > conflicts 
> > 
> > Unpacking knemo (from .../0.3.1/knemo_0.3.1-4_i386.deb) ...
> > dpkg - warning, overriding problem because --force enabled:
> >  trying to overwrite `/usr/share/icons/crystalsvg/22x22/actions/network_connected_lan.png', which is also in package knetworkconf
> > dpkg - warning, overriding problem because --force enabled:
> >  trying to overwrite `/usr/share/icons/crystalsvg/22x22/actions/network_disconnected_lan.png', which is also in package knetworkconf
> > dpkg - warning, overriding problem because --force enabled:
> >  trying to overwrite `/usr/share/icons/crystalsvg/22x22/actions/network_disconnected_wlan.png', which is also in package knetworkconf
> > dpkg - warning, overriding problem because --force enabled:
> >  trying to overwrite `/usr/share/icons/crystalsvg/22x22/actions/network_traffic_wlan.png', which is also in package knetworkconf
> > Setting up knemo (0.3.1-4) ...
> > 
> >         ii  knetworkconf            0.6.1-3ubuntu4          Network configurator for KDE
> >         allee[0] ~ # dpkg -L knetworkconf | grep crystalsvg
> >         /usr/share/icons/crystalsvg
> >         /usr/share/icons/crystalsvg/22x22
> >         /usr/share/icons/crystalsvg/22x22/actions
> >         /usr/share/icons/crystalsvg/22x22/actions/network_connected_lan.png
> >         /usr/share/icons/crystalsvg/22x22/actions/network_disconnected_lan.png
> >         /usr/share/icons/crystalsvg/22x22/actions/network_traffic_wlan.png
> >         /usr/share/icons/crystalsvg/22x22/actions/network_disconnected_wlan.png
> > 
> > I have not checked sid/sarge/breezy builds so this my be only
> > a backporting problem.  Too late here to check if this
> > is reported/fixed somewhere already, but I remember the problem was
> > mentioned on #kubuntu-devel and #ekhis weeks ago.
> 
> They fixed this filename clashes in breezy. knetworkconf now uses
> "knetwork_" as prefix for its icons. I don't know about hoary, but as
> knetworkconf and knemo already exist for hoary I assume that they took
> care of this too.

Good news!

Thx for comments and patches
Achim
> 
> 
> > Greetings from Munich to Karlsruhe ;)
> > Achim
> 
> Greetings from Karlsruhe to you all!
> 
> Michael
> 
> -- 
> ------------------------------------------------------------
> E-Mail: biebl at teco.edu
> WWW: http://www.teco.edu/
> 
> TecO (Telecooperation Office) Vincenz-Priessnitz-Str.1
> University of Karlsruhe 76131 Karlsruhe, Germany
> ------------------------------------------------------------
> 
> 

-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com