[Pkg-kde-extras] Re: kmplayer package review

[Fathi Boudra]

Le Mercredi 5 Avril 2006 16:19, Achim Bohnet a écrit :
> o Postinst and postrm do nothing so remove them.

remove them and you've got lintian complaining you doesn't call ldconfig
as we put lib in /usr/lib . It seems that last debhelper, if you package 
library call ldconfig, but for non-library package embedding libs nothing is 
done, and lintian complaien about it. So i've added postinst/postrm to call 
ldconfig.

> o copyright mention GPL and LGPL but there's only the GPL header from
>   src not LGPL.

right, i just added at the end:
The complete text of the GNU Library General Public License can be found in
`/usr/share/common-licenses/LGPL-2'.

* from http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile  :
Packages distributed under the UCB BSD license, the Artistic license, the GNU 
GPL, and the GNU LGPL should refer to the 
files /usr/share/common-licenses/BSD, /usr/share/common-licenses/Artistic, /usr/share/common-licenses/GPL, 
and /usr/share/common-licenses/LGPL respectively, rather than quoting them in 
the copyright file.

but can be polished by adding LGPL header.

> o copyright years missing for Koos in copyright

* not an absolute necessary as i understand for the copyright holder (see *):
In addition, the copyright file must say where the upstream sources (if any) 
were obtained. It should name the original authors of the package and the 
Debian maintainer(s) who were involved with its creation.

> o cdbs has utils.mk with has a list-missing target. This looks more
>   useful than the --list-missing from debhelpers.

Anyway i'll remove --list-missing , it isn't reliable for multi-package using 
debian/tmp sourcedir. Maybe utils.mk is better.

> o if kxvplayer can't be used standalone(?) it should be moved to
>   /usr/lib/kmplayer/ and full path used in kmplayer source code.
>   => one lintian warning to suppress less ;)

could ask koos about it :)

> Oh, I wasn't aware of this otherwise I would have pointed kubuntu devels to
> it :(
>
> I also a fan of add/keep of changelog and entires and keep a list of
> people that worked on the pkg at the top of copyright.
> IMHO this is polite if one uses parts or devired from their pkg (first
> impression is you started on your own).

If i have started with other people packaging, i'll have added their changelog 
and mention previous packaging, i'm polite :)
I confirm that i started the package on my own.

> Have a look at the kmplayer manpage.  Not much in it too, but a bit more.

right, i keeped kmplayer manpage in this state as we need to write the other 
manpages.

Thanks for the review :)

cheers,

Fathi