[Pkg-kde-extras] Bug#357359: FTBFS with G++ 4.1: extra qualification

[Martin Michlmayr]

Package: knemo
Version: 0.3.1-4
Severity: important
Tags: patch

Your package fails to build with G++ 4.1.  I'm filing this bug as
important for now, but when 4.1 will be the default compiler in
unstable (probably in a few weeks) I'll upgrade this to serious.

A patch is below.


> Automatic build of knemo_0.3.1-4 on bigsur by sbuild/mips 1.94
...
> 	depmode=gcc3 /bin/sh /build/tbm/knemo-0.3.1/./admin/depcomp \
> 	/bin/sh ../libtool --silent --mode=compile --tag=CXX g++ -DHAVE_CONFIG_H -I. -I/build/tbm/knemo-0.3.1/./kcm -I.. -I/usr/include/kde -I/usr/share/qt3/include -I.   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -W -Wpointer-arith -Wwrite-strings -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common  -c -o configdialog.lo `test -f '/build/tbm/knemo-0.3.1/./kcm/configdialog.cpp' || echo '/build/tbm/knemo-0.3.1/./kcm/'`/build/tbm/knemo-0.3.1/./kcm/configdialog.cpp
> /build/tbm/knemo-0.3.1/./kcm/data.h:48: error: extra qualification 'InterfaceSettings::' on member 'InterfaceSettings'
> /usr/lib/gcc/mips-linux-gnu/4.1.0/../../../../include/c++/4.1.0/bits/basic_string.h: In member function 'std::basic_string<_CharT, _Traits, _Alloc>::_Rep* std::basic_string<_CharT, _Traits, _Alloc>::_M_rep() const [with _CharT = char, _Traits = std::char_traits<char>, _Alloc = std::allocator<char>]':
> /usr/lib/gcc/mips-linux-gnu/4.1.0/../../../../include/c++/4.1.0/bits/basic_string.h:478:   instantiated from 'std::basic_string<_CharT, _Traits, _Alloc>::~basic_string() [with _CharT = char, _Traits = std::char_traits<char>, _Alloc = std::allocator<char>]'
> /usr/share/qt3/include/qstring.h:667:   instantiated from here
> /usr/lib/gcc/mips-linux-gnu/4.1.0/../../../../include/c++/4.1.0/bits/basic_string.h:283: warning: cast from 'char*' to 'std::basic_string<char, std::char_traits<char>, std::allocator<char> >::_Rep*' increases required alignment of target type
> make[3]: *** [configdialog.lo] Error 1
> make[3]: Leaving directory `/build/tbm/knemo-0.3.1/obj-mips-linux-gnu/kcm'
> make[2]: *** [all-recursive] Error 1


--- ./kcm/data.h~	2006-03-16 20:30:28.000000000 +0000
+++ ./kcm/data.h	2006-03-16 20:30:33.000000000 +0000
@@ -45,7 +45,7 @@
 
 struct InterfaceSettings
 {
-    InterfaceSettings::InterfaceSettings()
+    InterfaceSettings()
       : iconSet( 0 ),
         numCommands( 0 ),
         toolTipContent( 2 ),
--- ./knemod/data.h~	2006-03-16 20:31:46.000000000 +0000
+++ ./knemod/data.h	2006-03-16 20:31:53.000000000 +0000
@@ -43,7 +43,7 @@
 
 struct InterfaceData
 {
-    InterfaceData::InterfaceData()
+    InterfaceData()
       : existing( false ),
         available( false ),
         wirelessDevice( false ),
@@ -98,7 +98,7 @@
 
 struct InterfaceSettings
 {
-    InterfaceSettings::InterfaceSettings()
+    InterfaceSettings()
       : iconSet( 0 ),
         numCommands( 0 ),
         toolTipContent( 2 ),

-- 
Martin Michlmayr
http://www.cyrius.com/