[Pkg-kde-extras] Bug#455657: FTBFS with GCC 4.3: missing #includes

Frank Schoolmeesters frank_schoolmeesters at yahoo.com
Tue Feb 5 15:16:42 UTC 2008


tags 455657 fixed-upstream

Hi,

This bug is fixed upstream in CVS with the help of the patches of Fathi Boudra.
It should be ok now.
The upcomming Krusader-1.90.0 release will contain these patches.

thank a lot and bye,

Frank Schoolmeesters
Krusader Krew
http://www.krusader.org/


gcc-4.3.diff
-----------------------------------------
--- krusader/UserAction/expander.cpp
+++ krusader/UserAction/expander.cpp
@@ -10,6 +10,8 @@
 //
 //

+#include <algorithm>
+
 #include "expander.h"

 #include "../krusader.h"
-----------------------------------------


isoservice-desktop.diff
-----------------------------------------
--- iso/isoservice.desktop	2006/11/24 13:25:21	1.1
+++ iso/isoservice.desktop	2006/11/24 13:25:46
@@ -11,4 +11,4 @@
 Name=ISO9660 View
 Name[hu]=ISO9660 Nézet
 Name[fr]=Lecteur ISO9660
-Exec=
\ No newline at end of file
+Exec=kfmclient exec iso:%f
-----------------------------------------


string-comparison.diff
-----------------------------------------
--- krusader/Konfigurator/kgcolors.cpp	2007/07/22 10:36:24	1.1
+++ krusader/Konfigurator/kgcolors.cpp	2007/07/22 10:38:04
@@ -613,8 +613,10 @@
 void KgColors::serializeItem(class QDataStream & stream, const char * name)
 {
    stream << QString(name);
-   if( name == "KDE Default" || name == "Enable Alternate Background" ||
-       name == "Show Current Item Always" || name == "Dim Inactive Colors" )
+   if( (strcmp( name, "KDE Default") == 0)
+        || (strcmp( name, "Enable Alternate Background") == 0)
+        || (strcmp( name, "Show Current Item Always") == 0)
+        || (strcmp( name, "Dim Inactive Colors") == 0) )
    {
      bool bValue = generals->find( name )->isChecked();
      stream << QString( bValue ? "true" : "false" );
--- krusader/Konfigurator/kgcolors.cpp	2007/07/22 10:47:35	1.5
+++ krusader/Konfigurator/kgcolors.cpp	2007/07/22 10:48:45
@@ -621,7 +621,7 @@
      bool bValue = generals->find( name )->isChecked();
      stream << QString( bValue ? "true" : "false" );
    }
-   else if( name == "Dim Factor" )
+   else if( strcmp( name, "Dim Factor") == 0 )
      stream << QString::number(dimFactor->value());
    else
    {
-----------------------------------------



On Dec 11, 2007 4:48 AM, Martin Michlmayr <tbm at cyrius.com> wrote:
> Package: krusader
> Version: 1.80.0-1
> Usertags: ftbfs-gcc-4.3
>
> Your package fails to build with GCC 4.3.  Version 4.3 has not been
> released yet but I'm building with a snapshot in order to find errors
> and give people an advance warning.  In GCC 4.3, the C++ header
> dependencies have been cleaned up.  The advantage of this is that
> programs will compile faster.  The downside is that you actually
> need to directly #include everything you use (but you really should
> do this anyway, otherwise your program won't work with any compiler
> other than GCC).  There's some more information about this at
> http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include
>
> You can reproduce this problem with gcc-snapshot from unstable.  Note
> that Red Hat, Novell and Ubuntu have done some work getting packages
> to build with GCC 4.3 so there might be patches floating around
> somewhere.  I suggest you talk to your upstream.
>
> > Automatic build of krusader_1.80.0-1 on em64t by sbuild/amd64 0.53
> ...
> > g++ -DHAVE_CONFIG_H -I. -I/build/tbm/krusader-1.80.0/./krusader/UserAction -I../.. -I/usr/include/kde -I/usr/share/qt3/include -I.  -D__KJSEMBED__ -DQT_THREAD_SUPPORT  -D_REENTRANT -D_LARGEFILE64_SOURCE -DKDE_NO_COMPAT -DQT_NO_ASCII_CAST  -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common  -c -o expander.o /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp
> > In file included from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.h:17,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:13:
> > /usr/share/qt3/include/qstring.h: In member function 'char QChar::latin1() const':
> > /usr/share/qt3/include/qstring.h:194: warning: conversion to 'char' from 'int' may alter its value
> > /usr/share/qt3/include/qstring.h: In member function 'void QChar::setCell(uchar)':
> > /usr/share/qt3/include/qstring.h:219: warning: conversion to 'ushort' from 'int' may alter its value
> > /usr/share/qt3/include/qstring.h: In member function 'void QChar::setRow(uchar)':
> > /usr/share/qt3/include/qstring.h:220: warning: conversion to 'ushort' from 'int' may alter its value
> > /usr/share/qt3/include/qstring.h: In constructor 'QChar::QChar(uchar, uchar)':
> > /usr/share/qt3/include/qstring.h:264: warning: conversion to 'ushort' from 'int' may alter its value
> > /usr/share/qt3/include/qstring.h: In constructor 'QStringData::QStringData(QChar*, uint, uint)':
> > /usr/share/qt3/include/qstring.h:362: warning: conversion to 'unsigned int:30' from 'uint' may alter its value
> > /usr/share/qt3/include/qstring.h:362: warning: conversion to 'unsigned int:30' from 'uint' may alter its value
> > In file included from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:13:
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.h: In member function 'int exp_placeholder::parameterCount() const':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.h:71: warning: conversion to 'int' from 'size_t' may alter its value
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.h: In static member function 'static int Expander::placeholderCount()':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.h:164: warning: conversion to 'int' from 'size_t' may alter its value
> > In file included from /usr/share/qt3/include/qobject.h:45,
> >                  from /usr/share/qt3/include/qwidget.h:43,
> >                  from /usr/share/qt3/include/qdesktopwidget.h:40,
> >                  from /usr/share/qt3/include/qapplication.h:42,
> >                  from /usr/include/kde/kapplication.h:38,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../krusader.h:41,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:15:
> > /usr/share/qt3/include/qevent.h: In member function 'void QDropEvent::setAction(QDropEvent::Action)':
> > /usr/share/qt3/include/qevent.h:520: warning: conversion to 'unsigned char' from 'uint' may alter its value
> > In file included from /usr/share/qt3/include/qwidget.h:49,
> >                  from /usr/share/qt3/include/qdesktopwidget.h:40,
> >                  from /usr/share/qt3/include/qapplication.h:42,
> >                  from /usr/include/kde/kapplication.h:38,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../krusader.h:41,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:15:
> > /usr/share/qt3/include/qsizepolicy.h: In member function 'void QSizePolicy::transpose()':
> > /usr/share/qt3/include/qsizepolicy.h:122: warning: conversion to 'uchar' from 'uint' may alter its value
> > /usr/share/qt3/include/qsizepolicy.h:122: warning: conversion to 'uchar' from 'uint' may alter its value
> > In file included from /build/tbm/krusader-1.80.0/./krusader/UserAction/../krusaderview.h:46,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:16:
> > /usr/share/qt3/include/qpushbutton.h: In member function 'virtual void QPushButton::setIsMenuButton(bool)':
> > /usr/share/qt3/include/qpushbutton.h:91: warning: conversion to 'unsigned char:1' from 'int' may alter its value
> > In file included from /usr/include/kde/kservicetype.h:24,
> >                  from /usr/include/kde/kmimetype.h:33,
> >                  from /usr/include/kde/kfileitem.h:30,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../Panel/listpanel.h:37,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:18:
> > /usr/include/kde/ksycocaentry.h: In member function 'virtual void KSycocaEntry::save(QDataStream&)':
> > /usr/include/kde/ksycocaentry.h:104: warning: conversion to 'int' from 'Q_ULONG' may alter its value
> > In file included from /usr/include/kde/kfileitem.h:31,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../Panel/listpanel.h:37,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:18:
> > /usr/include/kde/kfilemetainfo.h: At global scope:
> > /usr/include/kde/kfilemetainfo.h:1237: warning: type qualifiers ignored on function return type
> > In file included from /usr/include/kde/klistbox.h:21,
> >                  from /usr/include/kde/kjanuswidget.h:27,
> >                  from /usr/include/kde/kdialogbase.h:27,
> >                  from /usr/include/kde/keditcl.h:26,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../Panel/listpanel.h:51,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:18:
> > /usr/share/qt3/include/qlistbox.h: In member function 'int QListBox::cellWidth() const':
> > /usr/share/qt3/include/qlistbox.h:191: warning: conversion to 'int' from 'long int' may alter its value
> > /usr/share/qt3/include/qlistbox.h: In member function 'int QListBox::cellWidth(int) const':
> > /usr/share/qt3/include/qlistbox.h:192: warning: conversion to 'int' from 'long int' may alter its value
> > In file included from /usr/include/kde/kjs/value.h:30,
> >                  from /usr/include/kde/kjs/interpreter.h:28,
> >                  from /usr/include/kde/kjsembed/kjsembedpart.h:31,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/../KrJS/krjs.h:11,
> >                  from /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:29:
> > /usr/include/kde/kjs/ustring.h: In member function 'unsigned char KJS::UChar::high() const':
> > /usr/include/kde/kjs/ustring.h:73: warning: conversion to 'unsigned char' from 'short unsigned int' may alter its value
> > /usr/include/kde/kjs/ustring.h: In member function 'unsigned char KJS::UChar::low() const':
> > /usr/include/kde/kjs/ustring.h:77: warning: conversion to 'unsigned char' from 'const short unsigned int' may alter its value
> > /usr/include/kde/kjs/ustring.h: In constructor 'KJS::UChar::UChar(unsigned char, unsigned char)':
> > /usr/include/kde/kjs/ustring.h:100: warning: conversion to 'short unsigned int' from 'int' may alter its value
> > /usr/include/kde/kjs/ustring.h: In member function 'unsigned char KJS::UCharReference::low() const':
> > /usr/include/kde/kjs/ustring.h:138: warning: conversion to 'unsigned char' from 'short unsigned int' may alter its value
> > /usr/include/kde/kjs/ustring.h: In member function 'unsigned char KJS::UCharReference::high() const':
> > /usr/include/kde/kjs/ustring.h:142: warning: conversion to 'unsigned char' from 'short unsigned int' may alter its value
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp: In function 'QString<unnamed>::separateAndQuote(QStringList, const QString&, bool)':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:348: error: 'transform' was not declared in this scope
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp: In member function 'virtual TagString<unnamed>::exp_Copy::expFunc(const ListPanel*, const TagStringList&, const bool&, Expander&) const':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:672: error: 'find_if' was not declared in this scope
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp: In member function 'virtual TagString<unnamed>::exp_Move::expFunc(const ListPanel*, const TagStringList&, const bool&, Expander&) const':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:703: error: 'find_if' was not declared in this scope
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp: In member function 'virtual TagString<unnamed>::exp_Each::expFunc(const ListPanel*, const QStringList&, const bool&, Expander&) const':
> > /build/tbm/krusader-1.80.0/./krusader/UserAction/expander.cpp:793: error: 'transform' was not declared in this scope
> > make[4]: *** [expander.o] Error 1
>
> --
> Martin Michlmayr
> http://www.cyrius.com/
>
>
>
>





More information about the pkg-kde-extras mailing list