[Pkg-kde-extras] Bug#505724: FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: soundkonverter
Version: 0.3.8-2
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with the upcoming GCC 4.4.  Version 4.4
has not been released yet but I'm building with a snapshot in order
to find errors and give people an advance warning.

GCC 4.4 cleaned up some more C++ headers.  You always have to #include
headers directly and cannot rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable.

> Automatic build of soundkonverter_0.3.8-2 on em64t by sbuild/amd64 0.53
...
> mkdir .libs
>  g++ -DHAVE_CONFIG_H -I. -I/build/tbm/soundkonverter-0.3.8/./src/metadata/audible -I../../.. -I/usr/include/kde -I/usr/share/qt3/include -I. -I/usr/include/taglib -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -DNDEBUG -DNO_DEBUG -O2 -g -O2 -g -Wall -O2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -c /build/tbm/soundkonverter-0.3.8/./src/metadata/audible/audibleproperties.cpp  -fPIC -DPIC -o .libs/audibleproperties.o
> /build/tbm/soundkonverter-0.3.8/./src/metadata/audible/audibleproperties.cpp: In member function 'void TagLib::Audible::Properties::readAudibleProperties(FILE*, int)':
> /build/tbm/soundkonverter-0.3.8/./src/metadata/audible/audibleproperties.cpp:77: error: 'fseek' was not declared in this scope
> /build/tbm/soundkonverter-0.3.8/./src/metadata/audible/audibleproperties.cpp:78: error: 'fread' was not declared in this scope
> make[6]: *** [audibleproperties.lo] Error 1
> make[6]: Leaving directory `/build/tbm/soundkonverter-0.3.8/obj-x86_64-linux-gnu/src/metadata/audible'

--- src/metadata/wav/wavproperties.cpp~	2008-11-14 17:00:40.000000000 +0000
+++ src/metadata/wav/wavproperties.cpp	2008-11-14 17:00:49.000000000 +0000
@@ -29,6 +29,7 @@
 
 #include "wavfile.h"
 
+#include <stdio.h>
 #include <netinet/in.h> // ntohl
 
 using namespace TagLib;
--- src/metadata/wav/wavfile.cpp~	2008-11-14 17:00:54.000000000 +0000
+++ src/metadata/wav/wavfile.cpp	2008-11-14 17:01:03.000000000 +0000
@@ -29,6 +29,8 @@
 #include <taglib/audioproperties.h>
 #include <taglib/tag.h>
 
+#include <stdio.h>
+
 namespace TagLib {
 ////////////////////////////////////////////////////////////////////////////////
 // public members
--- src/metadata/wav/wavfiletyperesolver.cpp~	2008-11-14 17:04:01.000000000 +0000
+++ src/metadata/wav/wavfiletyperesolver.cpp	2008-11-14 17:04:08.000000000 +0000
@@ -22,6 +22,7 @@
 #include "wavfiletyperesolver.h"
 #include "wavfile.h"
 
+#include <stdio.h>
 #include <string.h>
 
 TagLib::File *WavFileTypeResolver::createFile(const char *fileName,
--- src/metadata/audible/audibleproperties.cpp~	2008-11-14 16:57:02.000000000 +0000
+++ src/metadata/audible/audibleproperties.cpp	2008-11-14 16:57:07.000000000 +0000
@@ -29,6 +29,7 @@
 
 #include "taglib_audiblefile.h"
 
+#include <cstdio>
 #include <netinet/in.h> // ntohl
 
 using namespace TagLib;
--- src/metadata/audible/audibletag.cpp~	2008-11-14 16:57:33.000000000 +0000
+++ src/metadata/audible/audibletag.cpp	2008-11-14 16:57:42.000000000 +0000
@@ -28,6 +28,7 @@
 #include <taglib/tag.h>
 
 #include <netinet/in.h> // ntohl
+#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
--- src/metadata/audible/taglib_audiblefile.cpp~	2008-11-14 16:57:50.000000000 +0000
+++ src/metadata/audible/taglib_audiblefile.cpp	2008-11-14 16:57:56.000000000 +0000
@@ -29,6 +29,8 @@
 #include <taglib/tfile.h>
 #include <taglib/audioproperties.h>
 
+#include <cstdio>
+
 namespace TagLib {
 ////////////////////////////////////////////////////////////////////////////////
 // public members
--- src/metadata/audible/taglib_audiblefiletyperesolver.cpp~	2008-11-14 16:58:03.000000000 +0000
+++ src/metadata/audible/taglib_audiblefiletyperesolver.cpp	2008-11-14 16:58:09.000000000 +0000
@@ -22,6 +22,7 @@
 #include "taglib_audiblefiletyperesolver.h"
 #include "taglib_audiblefile.h"
 
+#include <stdio.h>
 #include <string.h>
 
 TagLib::File *AudibleFileTypeResolver::createFile(const char *fileName,

-- 
Martin Michlmayr
http://www.cyrius.com/