[Pkg-kde-extras] Bug#526166: FTBFS with GCC 4.4: missing #include

[Martin Michlmayr]

Package: tora
Version: 2.0.0-3
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with GCC 4.4, which has cleaned up some more
C++ headers.  You always have to #include headers directly and cannot
rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable or
gcc-4.4 from experimental.

> Automatic build of tora_2.0.0-3 on em64t by sbuild/amd64 0.53
...
> cd /build/tbm/tora-2.0.0/obj-x86_64-linux-gnu/src && /usr/lib/gcc-snapshot/bin/g++   -DCMAKE_BUILD -DTOMONOLITHIC -DQT_DLL -DQT_GUI_LIB -DQT_XML_LIB -DQT_SQL_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_DLL -DQT_CORE_LIB -DQT_GUI_LIB -DQT_THREAD_LIB -DTO_NO_ORACLE -DLIBPQ_DECL_CANCEL -DHAVE_POSTGRESQL_LIBPQ_FE_H -DHAVE_DLFCN_H -DHAVE_UNISTD_H -DHAVE_CONFIG_H -DQT_NO_DEBUG -g -O2 -g -Wall -O2 -O2 -Wall -I/build/tbm/tora-2.0.0/obj-x86_64-linux-gnu/src -I/build/tbm/tora-2.0.0/src -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtCore -I/build/tbm/tora-2.0.0 -I/build/tbm/tora-2.0.0/obj-x86_64-linux-gnu -I/usr/include/qt4/phonon -I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtAssistant -I/usr/include/qt4/QtDBus -I/usr/include/qt4/QtTest -I/usr/include/qt4/QtUiTools -I/usr/include/qt4/QtScript -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtDesigner -I/usr/include/qt4/Qt3Support -I/usr/share/qt4/mkspecs/default -I/build/tbm/tora-2.0.0/src/loki/include -I/build/tbm/tora-2.0.0/src/otl -I/usr/include/postgresql -I/usr/include/qt4/Qsci   -DTOVERSION=\"2.0.0\" -DDEFAULT_PLUGIN_DIR=\"/usr/share/tora/\" -DQT -DSCI_LEXER -o CMakeFiles/tora.dir/toqvalue.o -c /build/tbm/tora-2.0.0/src/toqvalue.cpp
> /build/tbm/tora-2.0.0/src/toqvalue.cpp: In static member function 'static QString toQValue::formatNumber(double)':
> /build/tbm/tora-2.0.0/src/toqvalue.cpp:264: error: 'sprintf' was not declared in this scope
> /build/tbm/tora-2.0.0/src/toqvalue.cpp:270: error: 'sprintf' was not declared in this scope
> make[3]: *** [src/CMakeFiles/tora.dir/toqvalue.o] Error 1
> make[3]: Leaving directory `/build/tbm/tora-2.0.0/obj-x86_64-linux-gnu'

--- src/toqvalue.cpp~	2009-04-29 17:02:16.000000000 +0000
+++ src/toqvalue.cpp	2009-04-29 17:02:23.000000000 +0000
@@ -47,6 +47,8 @@
 #include <QVariant>
 #include <QApplication>
 
+#include <cstdio>
+
 static int NumberFormat;
 static int NumberDecimals;
 
--- src/todebug.cpp~	2009-04-29 17:04:00.000000000 +0000
+++ src/todebug.cpp	2009-04-29 17:04:11.000000000 +0000
@@ -58,6 +58,7 @@
 #include "totool.h"
 #include "tocodemodel.h"
 
+#include <cstdio>
 #include <stack>
 
 #include <qcheckbox.h>
--- src/tomodeleditor.cpp~	2009-04-29 17:09:30.000000000 +0000
+++ src/tomodeleditor.cpp	2009-04-29 17:09:42.000000000 +0000
@@ -59,6 +59,8 @@
 #include <QSettings>
 #include <QAbstractItemModel>
 
+#include <cstdio>
+
 #include "icons/commit.xpm"
 #include "icons/copy.xpm"
 #include "icons/cut.xpm"
--- src/toresultview.cpp~	2009-04-29 17:17:49.000000000 +0000
+++ src/toresultview.cpp	2009-04-29 17:18:01.000000000 +0000
@@ -54,6 +54,8 @@
 #include "totool.h"
 #include "toresultlistformat.h"
 
+#include <cstdio>
+
 #include <qapplication.h>
 #include <qclipboard.h>
 #include <qcombobox.h>

-- 
Martin Michlmayr
http://www.cyrius.com/