[Pkg-kde-extras] Bug#583295: kaffeine: unable to edit duration of instant record, if filename has illegal characters from EPG

[Mika North]

Package: kaffeine
Version: 0.8.7-1
Severity: important

Kaffeine 0.8.7 (as is included in debian lenny) is unable to edit duration of instant record, if filename has illegal characters from EPG of DVB broadcast.

There already is a code line that filters out illegal characters from the filename that will actually be written on disk.
But the PROBLEM is that although the instant record starts correctly, kaffeine internally still remembers the unfiltered version of the filename
and if one tries to edit the recording duration, the illegal characters in the unfiltered filename will cause kaffeine to not accept the edited duration.


The fix to this bug is easy:

1. kaffeine source already has this line:

        rt->name = name.replace("/","_").replace(">","_").replace("<","_").replace(":","_").replace('"',"_").replace("\\","_").replace("|","_");
        
        in method void DvbPanel::newTimer( QString channel, QString name, QDateTime begin, QTime duration, bool warn )
        
        so just copy that line into another place, I will describe it here:
        
        In method void DvbPanel::setRecord()
        
        there are two lines like these:
        
        rt = new RecTimer();
        rt->name = s;
                        
        the line mentioned above should be copied immediately BEFORE these two lines and then modified to look like this:
                        
        s = s.replace("/","_").replace(">","_").replace("<","_").replace(":","_").replace('"',"_").replace("\\","_").replace("|","_");
                                
        After that fix, just recompile - And the bug is fixed.

-- System Information:
Debian Release: 5.0.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-2-686 (SMP w/2 CPU cores)
Locale: LANG=fi_FI.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages kaffeine depends on:
ii  hdparm           8.9-3                   tune hard disk parameters for high
ii  kdelibs4c2a      4:3.5.10.dfsg.1-0lenny4 core libraries and binaries for al
ii  libc6            2.7-18lenny2            GNU C Library: Shared libraries
ii  libcdparanoia0   3.10.2+debian-5         audio extraction tool for sampling
ii  libgcc1          1:4.3.2-1.1             GCC support library
ii  libogg0          1.1.3-4                 Ogg Bitstream Library
ii  libqt3-mt        3:3.3.8b-5+b1           Qt GUI Library (Threaded runtime v
ii  libstdc++6       4.3.2-1.1               The GNU Standard C++ Library v3
ii  libvorbis0a      1.2.0.dfsg-3.1+lenny1   The Vorbis General Audio Compressi
ii  libvorbisenc2    1.2.0.dfsg-3.1+lenny1   The Vorbis General Audio Compressi
ii  libx11-6         2:1.1.5-2               X11 client-side library
ii  libxcb1          1.1-1.2                 X C Binding
ii  libxext6         2:1.0.4-1               X11 miscellaneous extension librar
ii  libxine1         1.1.14-6                the xine video/media player librar
ii  libxine1-ffmpeg  1.1.14-6                MPEG-related plugins for libxine1
ii  libxine1-x       1.1.14-6                X desktop video output plugins for
ii  libxinerama1     2:1.0.3-2               X11 Xinerama extension library
ii  libxtst6         2:1.0.3-1               X11 Testing -- Resource extension 

kaffeine recommends no packages.

kaffeine suggests no packages.

-- no debconf information