[Pkg-kde-extras] Bug#669182: gtk2-engines-oxygen: LDFLAGS hardening flags missing

[Simon Ruderich]

Package: gtk2-engines-oxygen
Version: 1.2.2-1
Severity: normal
Tags: patch

Dear Maintainer,

The LDFLAGS hardening flags are missing because they are
overwritten in debian/rules. For more hardening information
please have a look at [1], [2] and [3].

The following patch fixes the issue.

diff -Nru gtk2-engines-oxygen-1.2.2/debian/rules gtk2-engines-oxygen-1.2.2/debian/rules
--- gtk2-engines-oxygen-1.2.2/debian/rules	2012-01-21 20:09:29.000000000 +0100
+++ gtk2-engines-oxygen-1.2.2/debian/rules	2012-04-15 18:54:39.000000000 +0200
@@ -7,9 +7,9 @@
 	dh_auto_configure -- \
 		-DDEBIAN_NO_DEMOS=1 \
 		-DCMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT=yes \
-		-DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed" \
-		-DCMAKE_MODULE_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed" \
-		-DCMAKE_EXE_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed"
+		-DCMAKE_SHARED_LINKER_FLAGS="$(LDFLAGS) -Wl,--no-undefined -Wl,--as-needed" \
+		-DCMAKE_MODULE_LINKER_FLAGS="$(LDFLAGS) -Wl,--no-undefined -Wl,--as-needed" \
+		-DCMAKE_EXE_LINKER_FLAGS="$(LDFLAGS) -Wl,--no-undefined -Wl,--as-needed"
 
 override_dh_makeshlibs:
 	dh_makeshlibs -X/usr/lib/$(DEB_HOST_MULTIARCH)/gtk-2.0

To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (for example with blhc [4]) (hardening-check
doesn't catch everything):

    $ hardening-check /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so
    /usr/lib/x86_64-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so:
     Position Independent Executable: no, regular shared library (ignored)
     Stack protected: yes
     Fortify Source functions: no, only unprotected functions found!
     Read-only relocations: yes
     Immediate binding: no not found!

(Position Independent Executable and Immediate binding is not
enabled by default.)

Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.

Regards,
Simon

[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
[4]: http://ruderich.org/simon/blhc/
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-extras/attachments/20120418/44b4e83f/attachment.pgp>