[Pkg-kde-extras] Bug#708169: kde-config-gtk-style: "Show Icons in GTK menus" is read incorrectly from current configuration - fixed upstream

Ralf Jung post at ralfj.de
Tue May 21 12:15:23 UTC 2013


>> this bug actually had already been fixed upstream when I reported it, it
>> just hasn't been merged to master:
>> https://projects.kde.org/projects/extragear/base/kde-gtk-config/repository/revisions/8f23071c6e7719970be9383246df8f321131048b
>> Another bug concerning mis-matched boolean configurations was also fixed:
>> https://projects.kde.org/projects/extragear/base/kde-gtk-config/repository/revisions/f47a8380c76f42d7807fcd1e5bf82a540faa8d84
> Thanks for links. It is a pity that too late: I prepared similar changes by
> myself [1]. Eh, next time I will look into other git branches.
Me, too ;-)

> [1] http://anonscm.debian.org/gitweb/?p=pkg-kde/kde-extras/kde-gtk-config.git
> I am going to fix desktop file and updated package will be uploaded soon.
Great :)
However, doesn't your patch now skip the first line of the file?

    for(QString line = flow.readLine(); !flow.atEnd(); ) {
        line = flow.readLine();

Compared to

    for(QString line; !flow.atEnd(); ) {
        line = flow.readLine();

which is upstream.

Kind regards

More information about the pkg-kde-extras mailing list