[Pkg-kde-extras] Bug#807853: k3b: FTBFS with FFmpeg 2.9

[Andreas Cadhalpun]

Hi Pino,

Thanks for your quick reply.

On 08.01.2016 18:12, Pino Toscano wrote:
> Yes, I've seen the patch in #807853, and a couple of review requests on
> KDE's reviewboard.

Could you please post links to upstream discussion about this or mark
the bug as forwarded?

> Let me take this opportunity to "reverse the issue": is your upstream
> aware that the continuous API breaks in each new stable series only
> waste time on the users' side?

I sense frustration in these words, but let's get the facts straight:
 * The last four stable series (2.5.*-2.8.*) didn't break the API.
 * Adapting to the new APIs is no waste of time, rather maintenance cost,
   also improving the API using program in the process, as the old APIs
   were deprecated for a reason.

And yes, the upstream developers are aware of that maintenance cost,
I made sure of that. Please go and read the discussion upstream [1][2].
And I can understand your frustration, after all, I'm the one who wrote
patches for all affected Debian packages.

> Just look at the affected code in k3b,
> plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp: many defines and ifdef's,
> just to make the very same code do the very same job, nothing less and
> nothing more.

I'm well aware how this file looks, as I wrote a patch for it.
And most of these ifdef's could just be removed, unless you need to
build this in ancient environments...

> Sure, if I don't get around to test your patch or to integrate eventual
> upstream fixes the plugin will need to be disabled, but honestly I don't
> see how this would be in favour of our users.

That's why I provided a patch, which should be more than enough to fix
this issue properly for any reasonably maintained software.

Best regards,
Andreas


1: https://lists.libav.org/pipermail/libav-devel/2015-July/071229.html
2: https://ffmpeg.org/pipermail/ffmpeg-devel/2015-July/176439.html