[Pkg-kde-talk] Re: [Pkg-kde-commits] rev 1255 - in people/chrsmrtn: . qt-x11-free qt-x11-free/debian qt-x11-free/debian/maintain qt-x11-free/debian/maintain/man qt-x11-free/debian/patches

[Brian Nelson]

On Tue, Jul 12, 2005 at 04:15:50AM +0000, Christopher Martin wrote:
> On July 11, 2005 19:10, Adeodato Simó wrote:
> >   Wow, this is lots of good stuff. Way to go, Christopher! :)
> 
> Thanks, I just hope I haven't messed anything up! Peer review, especially, 
> but not exclusively, from Brian Nelson (due to his Qt experience), would be 
> really great.

I haven't tested any binaries yet, but I looked at a diff of the changes
you made and everything looks OK to me so far.  Just a couple things to
point out:

* You changed the "firebird2-dev [darwin-i386 freebsd-i386 ...]"
  dependency to simply "firebird2-dev [i386]".  Do you know why it was
  done that way previously and if your change will have any negative
  effects?

* Since you're removing libqt3-dev, you might want to make libqt3-mt-dev
  provide it.  I'm not entirely sure that's a good idea, but it's
  something to consider.

* You should apply the patch in #317500, or otherwise the package will
  FTBFS.

-- 
Society is never going to make any progress until we all learn to
pretend to like each other.