[Pkg-kde-talk] Re: [Pkg-kde-commits] rev 1349 - trunk/packages/qt-x11-free/debian

[Adeodato Simó]

> Author: chrsmrtn-guest
> New Revision: 1350
> Modified:Sat, 23 Jul 2005 00:48:15 +0200
>    trunk/packages/qt-x11-free/debian/control
> Log:
> Remove 'c102' from libqt3-dev and libqt3-mt-dev's depends (on libqt3...).

  Good one, thanks a lot!

> New Revision: 1351
> Removed:
>    people/chrsmrtn/qt-x11-free/debian/patches/30_gcc4_build.dpatch
> Modified:
>    people/chrsmrtn/qt-x11-free/debian/patches/00list
> Log:
> Remove unnecessary gcc4 patch.

> -30_gcc4_build.dpatch
>  31_gcc4_buildkey.dpatch

  And hum, 31_gcc4_buildkey must really really go into trunk (otherwise
  the buildkey would check after a new upload, if the compiler changed
  in between). Will commit now.

> New Revision: 1349
  
  I have a couple comments about this one.

> Modified:
>    trunk/packages/qt-x11-free/debian/control
> Log:
> Add new libxi-dev to the build-depends, dev package depends.

  Can we get a changelog entry for this? But more importantly:

> Since this is needed for other KDE packages,

  Is this confirmed? If so, shouldn't these packages be depending
  themselves on libxi-dev, instead of relying on qt3-dev doing so?

> having this pulled in is handy.
> In Qt, required for (at the very least) tablet support.

  I'd prefer to add the build-dependency only when needed, i.e. in -5
  when tablet support is added.

  Cheers,

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
ech`echo xiun|tr nu oc|sed 'sx\([sx]\)\([xoi]\)xo un\2\1 is xg'`ol