[Pkg-kde-talk] KDE 3.4 package underway

[Adeodato Simó]

* Christopher Martin [Wed, 02 Mar 2005 15:04:12 -0500]:

> The RC1 tarballs dato made available have Makefile.in files provided. I 
> don't know if dato created them, or whether he just obtained them this way. 

  They were created. It seems that they don't do it for betas.

> Anyway, we patch them, and everything is fine. If, however, you take a CVS 
> checkout, then these files are generated only when make -f 
> admin/Makefile.common dist is run. The 99_buildprep.diff then contains the 
> complete Makefile.in files. The patchsys tries -p0 first, and this actually 
> succeeds in creating these files, but in a subdirectory of the build 
> directory, e.g. kdelibs-3.4.0/kdelibs-3.4.0/Makefile.in. This is when we 
> have to force -p1.

  Ahhh, thanks for this explanation.

> I think it's nice to have all the build-system stuff in a nice, separate 
> patch. It can then be removed easily (just unpatch), re-applied, etc. It's 
> more a matter of "style" and of how you like to work than an important 
> technical decision, though as a group we should probably try to be 
> consistent. Comments from anyone and everyone?

  As I said, I agree that the little effort is worth it. Also, note that
  when doing this, "unpack the orig.tar.gz and put the debian/ from SVN
  on it" just works out the box (i.e., no chance of not shipping
  autotools changes because one used the svn dir but forgot to run make
  -f admin/Makefile.common dist).

  Cheers,

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
As an adolescent I aspired to lasting fame, I craved factual certainty,
and I thirsted for a meaningful vision of human life -- so I became a
scientist. This is like becoming an archbishop so you can meet girls.
                -- Matt Cartmill