[Pkg-kde-talk] Re: Please allow kdenetwork and kdelibs into Sarge

[Steve Langasek]

--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 09, 2005 at 08:32:54AM -0400, Christopher Martin wrote:
> kdenetwork 4:3.3.2-3, replacing 4:3.3.2-1 in Sarge, fixes a number of bug=
s,=20
> including several that are RC. These packages have been in Sid for some=
=20
> time, but held out due to missing buildds, so they've proven themselves=
=20
> solid. The most recent upload, from late April, contained only packaging=
=20
> changes:

Approved (though still waiting on a sarge upload).

Going forward, it would be nice if you would check whether uuencoding
something that's already a diff (and, er, not changing the name of a diff
just because the date changed), so that changes can be reviewed using
interdiff alone.  I imagine this is being done here to guard against dpkg's
failure to use -a when generating diffs, and I suspect it's not actually
necessary if you've got everything in a diff file *anyway*, because the diff
header itself ought to mark the file as ascii.

> As for kdelibs, the sole change between 4:3.3.2-5 and 4:3.3.2-6 is that w=
e=20
> added a very small patch (from upstream) to upstream's latest security fi=
x,=20
> which caused regressions reading some image files. Definitely worth getti=
ng=20
> into Sarge, even if the problem doesn't seem to have security implication=
s.
>=20
> 23_kimgio_fix.diff
> --- kde.orig/kimgio/rgb.cpp
> +++ kde.patched/kimgio/rgb.cpp
> @@ -272,7 +272,8 @@ bool SGIImage::readImage(QImage& img)
>         // sanity ckeck
>         if (m_rle)
>                 for (uint o =3D 0; o < m_numrows; o++)
> -                       if (m_starttab[o] + m_lengthtab[o] >=3D m_data.si=
ze())=20
> {
> +                       // do not convert to >=3D
> +                       if (m_starttab[o] + m_lengthtab[o] > m_data.size(=
))=20
> {
>                                 kdDebug(399) << "image corrupt (sanity ch=
eck=20
> failed)" << endl;
>                                 return false;
>                         }

The accompanying changelog isn't very enlightening; what filetypes are
broken, and why?  Can you offer a pointer to discussion of this bug?

--=20
Steve Langasek
postmodern programmer

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCgJ7FKN6ufymYLloRAkP2AKDAi2dswjApKUA1GkTmOWA3v+EfWQCgm0Gp
mSlfqX/dJBCtiYvYAzB9+Gs=
=yaOk
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--