KDE 4 class for cdbs
Armin Berres
trigger at space-based.de
Tue Feb 12 11:56:03 UTC 2008
On Tue, 12 Feb 08 12:28, Peter Eisentraut wrote:
> | DEB_CMAKE_EXTRA_FLAGS += \
> | -DCMAKE_BUILD_TYPE=Debian \
>
> I don't see "Debian" documented as a valid value for this variable. What is
> this supposed to do? Should this be in the cmake class?
It is defined in this patch:
<http://svn.debian.org/wsvn/pkg-kde/branches/kde4/packages/kdelibs/debian/patches/08_add_debian_build_type.diff>
Does every KDE 4 app use FindKDE4Internal.cmake? If yes it should be in
the class, otherwise it shouldn't.
> | -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed" \
> | -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed" \
> | -DCMAKE_EXE_LINKER_FLAGS="-Wl,--no-undefined -Wl,--as-needed"
>
> These linker options are of course useful, but are we sure enough that they
> work with all KDE-related software packages?
No, there are definitely cases where the flags don't work. But these
packages should be fixed ;)
> | binary-install/$(DEB_SOURCE_PACKAGE)-doc-html::
>
> This also belongs in the team file.
I hope we can kill this completely. I didn't hear anyone speaking in
favour of the html documentation.
Greetings,
Armin
More information about the pkg-kde-talk
mailing list