rev 11376 - in branches/kde4/packages/kdebase-workspace/debian: . patches

[Sune Vuorela]

On Monday 07 July 2008 18:10:01 Ana Guerrero wrote:
> On Mon, Jul 07, 2008 at 05:38:11PM +0200, Sune Vuorela wrote:
> > On Monday 07 July 2008 16:54:26 Ana Beatriz Guerrero López wrote:
> > > -    * ksysguard now depends on ksysguardd.
> > > +  * ksysguard now recommends on ksysguardd.
> > >
> > >
> > > Modified: branches/kde4/packages/kdebase-workspace/debian/control
> > > ===================================================================
> > > --- branches/kde4/packages/kdebase-workspace/debian/control	2008-07-07
> > > 14:25:58 UTC (rev 11375) +++
> > > branches/kde4/packages/kdebase-workspace/debian/control	2008-07-07
> > > 14:54:26 UTC (rev 11376) @@ -132,7 +132,8 @@
> > >  Package: ksysguard
> > >  Section: admin
> > >  Architecture: any
> > > -Depends: ${shlibs:Depends}, ksysguardd (= ${binary:Version})
> > > +Depends: ${shlibs:Depends}
> > > +Recommends: ksysguardd (= ${binary:Version})
> > >  Description: System Guard for KDE 4
> > >   KDE System Guard allows you to monitor various statistics about your
> > > system. .
> >
> > This is wrong.
> >
> > You are trading less than 300K for a bad user experience - and even 300K
> > that there is a big chance that people already have installed. And kde3
> > also have the same dependency.
>
> Problem here about "bad user experience" is the not clear error message, we
> should ask upstream change it.

When reading the code, the message is quite clear. It is as far as I 
understood the code not intended to be shown as a message if daemon is 
unavailable, but more as a error message for other issues, like networking 
issues. 
And the connection to the ksysguardd running on localhost seems to be a 
fallback thingie if nothing else is available.

From the source:
  //if no hosts are specified, at least connect to localhost
  if(dnList.count() == 0)
    KSGRD::SensorMgr->engage( "localhost", "", "ksysguardd", -1);

(and there are a couple of other similar things)

> > Please revert or come with a *justification* other than "I don't use it".
>
> ksysguard can do some stuff without ksysguardd, plus you can use it for
> remote monitoring, so ksysguardd is *optional*. 

It doesn't look like it is optional, but works anyway. 

It is by the way quite normal for system monitor thingies to monitor localhost 
by default without extra effort.

I think we should put it in as Depends for now and downgrade if upstream 
considers it optional. I can write them a email (or locate on irc)

And it is still just a few hundred kb that we are pulling in.

> >  - and please don't hide the changes in your commit messages.
>
> I did not  :?

The following is the *full* commit message:  "new snapshot (85+) redo patches"

/Sune

-- 
Man, how can I ping the port 7 of a analogic window over the forward?

First you neither should ever log on a case to the tool, nor must mount a 
periferic on the memory, this way from Photoshop you must log from a coaxial 
DVD head of the GUI on a IRC FPU.