RFS: k4dirstat

[Pino Toscano]

Hi,

Alle domenica 26 giugno 2011, Jerome Robert ha scritto:
> I am looking for a sponsor for my package "k4dirstat".

I am not a DD (yet) so I cannot upload your package, but I can give you 
a (quick?) review of your packaging (so I could be missing something):

* debian/changelog
- the text for closing a bug does not match the patterns used for that;
  instead of "close #x" use "closes: #x", which will work (you can
  verify the result looking at the output of `dpkg-parsechangelog`, and
  at its Closes: field)
	
* debian/control
- the part for the source misses the Priority header
- kdirstat: for the short description, I'd put something like
  "transitional package for k4dirstat"
- kdirstat: it is an empty transitional package, so can be
  Architecture: all

* debian/copyright
- misses the copyright for the packaging itself
- a quick look shows that some sources are licensed are GPL (v2+?) and
  some are LGPL (v2+?), but you don't specify the LGPL license
- you refer to the "GNU General Public License" to
  /usr/share/common-licenses/GPL, but it really seems GPL v2+, so you
  must say that and refer to the "GPL-2" and "GPL-3" common-licenses 
  files (so no generic "GPL")
- it misses the copyright indications for the sources, like:
    Copyright (C) 20xx-20yy by Foo Bar <foo at bar.org>

* debian/kdirstat.install
- you don't really need this empty file

* debian/k4dirstat.install
- the line for "hicolor" icons is repeated three times, but ...
- ... in practice you don't need even this file, see "rules"

* debian/rules
- make use of pkg-kde-tools and of the 'kde' addon for `dh`:
  dh $@ --with kde
  this will make the packaging adapt automatically to kde-specific steps
  needed, like avoid compressing .docbook files; see the README.Debian
  of pkg-kde-tools about the build-dependencies (and their versions)
  needed
- even if the source has two binaries, in practice you need to put
  everything in one of the two; you can use a small trick with 
  debhelper, i.e. directly install everything to the final location:
  override_dh_auto_install:
    dh_auto_install --buildsystem=kde --destdir=debian/k4dirstat
  (assuming you make use of the kde addon as said above)
  with this trick, you don't need any .install file at all

> The package appears to be lintian clean.

Erm, not really:

$ lintian -I -E k4dirstat_2.7.0~git20101011-1_amd64.changes
I: k4dirstat source: debian-watch-file-is-missing
W: kdirstat: new-package-should-close-itp-bug
W: kdirstat: copyright-without-copyright-notice
W: kdirstat: no-priority-field
W: k4dirstat: new-package-should-close-itp-bug
W: k4dirstat: copyright-without-copyright-notice
W: k4dirstat: no-priority-field
W: k4dirstat: binary-without-manpage usr/bin/k4dirstat

however, most of the issues above are covered by notes above; what is 
not covered are the two lintian items about the watch file and the 
manpage; note you don't really need to fix them to enter Debian, even if 
you are suggested to do so.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20110626/0645a444/attachment.pgp>