RFS libdbusmenu-qt (Re: Qt Multiarch Transition)

[Praveen Arimbrathodiyil]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/02/11 14:31, Pino Toscano wrote:
> Alle domenica 2 ottobre 2011, Praveen A ha scritto:
>> Someone please review the changes and upload. All changes are in
>> git repo.

Thanks for your review. Sorry for getting back so late on this.

> Some notes (in random order) about the packaging: - why the usage
> of postinst and prerm to create the symlink for jquery.js? isn't a
> .links file for dh_link (hence a static symlink) enough for this
> job?

removed postinst and prerm, now using .links file.

> - in all the packages descriptions and in the doc-base abstract
> there is "and import their menus over DBus.", where this "DBus"
> occurrency should be "D-Bus"

changed.

> - copyright misses the current year (2011) for your debian/*
> changes

changed.

> - in the doc-base file, Files should most probably be something
> like Files: /usr/share/doc/libdbusmenu-qt-doc/*.html 
> /usr/share/doc/libdbusmenu-qt-doc/search/*.html (given it
> represents all the HTML files of the documentation)

changed.

> - what's the point of a symbols file, if you set a strict shlibs 
> manually with dh_makeshlibs? Either drop the strict shlibs, or the 
> symbols file

I will change it after I fix dbg package.

> - most probably you can avoid 001-dbusmenu-doc-path.diff at all,
> and just move the files to the right place using a 
> libdbusmenu-qt-doc.install like: usr/share/doc/dbusmenu-qt/
> usr/share/doc/libdbusmenu-qt-doc (this would avoid a (most
> probably) unnecessary patch)

changed.

> - the libdbusmenu-qt2 description talks about "shared libraries",
> while there is actually just one

changed.

> - in the libdbusmenu-qt-doc description, "html" should be properly 
> all uppercase

changed

> - given you need an upload to NEW, why not use the opportunity to
> add a libdbusmenu-qt-dbg debug package?

I followed steps mentioned in http://wiki.debian.org/DebugPackage but
the created package does not have any shared library. Is there any
other step I need to do?

All changes made in the git repo.

Thanks
Praveen
> 
> 
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPd1uIAAoJEM4fnGdFEsIqbN0P/0ojGVs2Hy6Xzy2HpsMEmNFY
fpColUWtzM3DRIigDwQKjNWwiLMbRS8QWHwM3DuHPUekXR4n5/0/1T36uHrt13yp
QWulakNRtjj/yiVRtm2huD1d5PXW3LQOAtRzFLwgsT5ZJ/4/k7uUECusS2Hsq0Ej
PTCZEl8Dr5A4nBPrICFXyt3+wqfO4hQrMjbOYrsLNNsrFsKuipHd4Fq5O0/ihwB0
14CAAWSBFNc03EIG8iSnYkTkGv9r7tGysJTxWYWPZt8C8FVVPYDa3YOvJNKzMaTD
M/c9YgTcnR4ABbltYsG9ayxeJECc/Hu9LtvKqLE8gx7McbIGE152R6VRsib9s2of
9s2yRg0CW8WfwWS8nsE6CIUNLyxuGYkogwXD1Iu4ft6li4TSPjuOTc9nAjUQiXIa
qsR932z2RCKfgyV6ES2LYrLjKDOI+XHmxZoaRT6WAArH7BLsurkzNRjmiZodEhcR
QXLHwbJbuCZa/Kf7IupnLG8g5kfCX7Z45fRVH9WrqW81Ws+ucIwowUuuoDp6qCjs
Xtz8vYUnkdyL0IKRv4A1BYF6wU9tvMvQ9dT/56GjTr7HJkmvSaboKzE93uyu8O8J
lvWCHNCknU8TLhP9GNnx6tb7DmPxbkgUb9xMr2oimbqAsauIpkgs2XNMiXgjNtCs
uSU4qK6Vi+So4pT9pXHB
=Xk+c
-----END PGP SIGNATURE-----