Bug#704833: (pre-approval) unblock: virtuoso-opensource/6.1.4+dfsg1-7

[Ralf Jung]

Package: release.debian.org
Severity: normal
User: release.debian.org at packages.debian.org
Usertags: unblock

Please unblock package virtuoso-opensource

Hi Release-Team!

We, the Qt/KDE team, would like you to check if the following changes
are within what you are expecting for getting an unblock.

The most important stuff was solving RC #704521 [2], but while looking at it I
found other issues. The complete list of changes in the init script is:

* I removed "set -e" from the script because (according to a footnote in
policy [1]) lsb/init-functions is incompatible with that option.
Furthermore, even the script itself did not deal with that option
correctly, e.g., a non-0 exit code from start-stop-daemon would have
terminated the script without proper logging. This also allowed for
simplification where the $errcode was used previously.

* The RC bug about stopping the daemon [2] is fixed in the stop_server
function by using start-stop-daemon with a proper --retry argument,
instead of killproc. The script has two modes of operation (one to use
root, one with a dedicated user for the daemon), hence there are two
branches in stop_server - I did not simplify this to keep the diff smaller.

* The script used to INT the server due to [3], but according to
upstream documentation [4] TERM should be used in rc.d scripts, so
that's what it does now.

* I removed reload_server and the reload directive because virtuoso does
not support reloading (it used to print an error there, and then exit 0).

* I removed force-stop since (a) it's not mandated or even recommended
by anything (b) stop itself will already use KILL if TERM does not work
and (c) it essentially just duplicated the retry-functionality of
start-stop-daemon, but with way too long delays (60s).

* The changes for the restart directive ensure that the script handles
failure to stop the server appropriately. They also remove the 60s-delay
between stop and start (which is no longer needed now that stop_daemon
properly waits for virtuoso to quit).

[1] http://www.debian.org/doc/debian-policy/footnotes.html#f81
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704521
[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632060
[4] http://docs.openlinksw.com/virtuoso/signalsandexitcodes.html

Diffstats:
 changelog                    |   15 ++++
 control                      |    5 -
 virtuoso-opensource-6.1.init |  131
++++++++++---------------------------------
 3 files changed, 49 insertions(+), 102 deletions(-)

Kind regards,
Ralf Jung
Debian Qt/KDE team

unblock virtuoso-opensource/6.1.4+dfsg1-7

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (990, 'testing'), (100, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.6 (SMP w/4 CPU cores)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtuoso.diff
Type: text/x-diff
Size: 8690 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20130406/f0769f7e/attachment.diff>