qtwebkit 2.3 review

Dmitry Shachnev mitya57 at gmail.com
Sun Jul 27 13:31:46 UTC 2014

Hi Andreas,

I took a look at your qtwebkit branch. It mostly looks good, some notes:

- Calling dh_install in override_dh_auto_install target is wrong. Please
  properly split these two stages.
- Also, please use .install files where possible, instead of manually
  copying files in debian/rules.
- In Ubuntu, copyright file is much more complete than yours. I think
  you should borrow some lines from there (but be careful, some parts of
  it are wrong, like the last two lines).
- The dh_builddeb override is no longer needed.


Dmitry Shachnev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-kde-talk/attachments/20140727/72017c77/attachment.sig>

More information about the pkg-kde-talk mailing list