qtserialbus review

[Scarlett Clark]

All issues addressed and pushed.
Thank you!
Scarlett


On Mon, May 21, 2018 at 7:02 AM, Lisandro Damián Nicanor Pérez Meyer <
perezmeyer at gmail.com> wrote:

> Hi!
>
> First of all, we don't want not-normal branches in the repos. You can
> always
> clone it in salsa and I can check that clone. Why? because someone else
> might
> have cloned your branch and then becomes able to resurrect it by accident.
>
> That being said I've found your work pretty nice, so I went ahead and
> merged
> it on master and removed your branch. Please feel free to continue from
> there.
>
> = debian/control:
>
> - Source: this is a new source, so it should be named
> qtserialbus-everywhere-
> src as upstream does.
>
> - Uploaders: you did the packaging but did not add yourself to it. That
> it's
> just fine if you are trying to reduce our workload without jumping in to
> maintain it. Otherwise feel free to add yourself there.
>
> = debian/copyright:
>
> - Some parts of the documentation (not listed here) are under the [G]FDL.
> Note
> that this requires special checking from us, as within Debian
> "GFDL-licensed
> works without unmodifiable sections are free" (Debian GR 2006-01).
>
> - The commercial license part is no-op for us, so we simply don't mention
> it.
>
> - Line 12: should be 2015-2017 (see tests/auto/qmodbuspdu/tst_
> qmodbuspdu.cpp)
>
> - You are missing at least Andre Hartmann. Tip: I normally use grep -iRn
> copyright * | grep -v "foo", where foo is something I already have in the
> copyright file.
>
> I have not yet built the package. Please fix debian/copyright and then
> I'll
> continue.
>
> Thanks!
>
> --
> I'm doing a (free) operating system (just a hobby, won't be big and
> professional like gnu) for 386(486) AT clones.
>   Linus Benedict Torvalds.
>
> Lisandro Damián Nicanor Pérez Meyer
> http://perezmeyer.com.ar/
> http://perezmeyer.blogspot.com/
>
> --
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-kde-talk
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20180531/14c62cd1/attachment.html>