Packaging the Elisa music player

[Aurélien COUDERC]

(with the correct list address…)

Le 03/09/2018 à 16:27, Sandro Knauß a écrit :
> Hey,

Hi Sandro.

> thanks for starting packaging elisa. Most of the things look fine and it
> builds...

Of course it does. :)
And thanks for the review !

> Here are a list of small issues I saw while reviewing:
> * You can remove the debian/source/lintian-overrides, lintian knows about this
> stuff now...

Done.

> * add signature support in watch file.
>  - uscan warn: Possible OpenPGP signature found at:
>  -   https://download.kde.org/stable/elisa/0.2.1/elisa-0.2.1.tar.xz.sig
>  - * Add opts=pgpsigurlmangle=s/$/.sig/ or opts=pgpmode=auto to debian/watch
>  - * Add debian/upstream/signing-key.asc.
>  -   See uscan(1) for more details

Done.

> * elisa: spelling-error-in-binary usr/lib/x86_64-linux-gnu/elisa/
> libelisaLib.so.0.1 allow to allow one to
>  - did you send a fix to upstream?

Done, the patch has the « Forwarded: » url also.

> * copyright for CC-BY-SA 4.0 is not complete please add the complete text like
> recommended by lintian:
> https://creativecommons.org/licenses/by-sa/4.0/legalcode.txt

Fixed.

> * you missed some files with extra license:
> Files: po/ca/elisa.po
>        po/ca/kcm_elisa_local_file.po
>        po/ca at valencia/*
>        po/uk/elisa.po
>        po/uk/kcm_elisa_local_file.po
> Copyright: 2016-2018, This_file_is_part_of_KDE
> License: LGPL-2.1+3+KDEeV

Oops, I missed that from my licensecheck somehow, thanks.

> and one author:
> 2012, Aleix Pol Gonzalez <aleixpol at blue-systems.com>

Added, thanks.

> * add a copyright section for debian files. A good practice is to use the main
> license of the project, so it is easy to send patches upstream.

Done.

> * as the documentation is not that big, I recommend not to split it to an own
> package.

Not done. :)

>> As it uses Qt/KDE technologies and targets good integration with Plasma, I
>> think it makes sense to package it under the debian-qt-kde umbrella.
>
> yeah sure. Just to make it clear, you as uploader needs to care about
> bugreports and updates etc. We as team can help you and hopefully you will
> help also at other places within the team...

Perfectly clear, and that is my goal !
I’m usually around on #debian-qt-kde and will look around for ideas of other tasks.
One I have already is the plasma integration plugin for firefox that I haven’t
seen packaged so far.

> Please use our talk list for discussions and asking for reviews etc, there the
> talks within the team happens. debian-qt-kde is only for bugreports/automatic
> stuff mostly.

OK, I was previously only subscribed to debian-qt-kde, but now I also joined
this talk list.

> Leave me a note if you fixed the issues, than I can upload your package. If
> you have any questions or something is unclear please ask!

I think all the above is now OK in git.
Feel free to have another look and upload as you see fit.


Cheers,
--
Aurélien

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20180914/2c7c11be/attachment.sig>