Packaging exiv2 0.27

Simon Frei freisim93 at gmail.com
Sat Aug 17 12:10:43 BST 2019


On 17/08/2019 02:10, Steve Robbins wrote:
>
> Oh.  What I meant is to fix the code to use <stdint.h> rather than typedef'ing 
> things wrongly.   Specifically in XMP_Const.h, remove "#if XMP_MacBuild" or 
> replace it with "#if 1" to use the typedefs int8_t, etc.
Ok, I now cherry-picked a minimal set changes from xmpsdk 2016.7
concerning unix/linux, which fixes the sizeof(XMP_Int32) = 8 mistake (I
don't think there's any point in adding more changes regarding mac/win
for debian packaging). I do not disagree with fixing this, so just for
completeness my reasoning for not doing so before: I partly agree with
upstream, that while the typedef is clearly incorrect (as shown by the
failing asserts), who knows if some behaviour depends on the incorrect
typedef. It's unlikely, but possible.


Also what's the preferred way for reviewing this - I guess due to
merging a new upstream release patches are out of the question. Would
you prefer an MR or is the branch on my salsa fork fine?



More information about the pkg-kde-talk mailing list