Packaging review for the Elisa music player

[Aurélien COUDERC]

Le 15/01/2019 à 19:10, Sandro Knauß a écrit :
> Hey	 Aurélien,
> 
> d/copyright:
> * You have a block "License: LGPL-2 or GPL-3"
> you should remove this block and replace it with:
> License: LGPL-2
> ...
> License: GPL-3

Fixed, thanks.

>> - elisa seems heavily based on QML, although there are no runtime 
> dependencies on QML modules
>> - autopkgtest is meant to test packages as available in the archive, not to 
> be a generic CI for running the test suite on a new package build; the current 
> 'testsuite' autopkgtest does not test the in-archivepackage, and as such it is 
> not a valid autopkgtest test (and it can even produce wrong results)
> 
> Because elisa uses QML and QML has no  equivalent of ABI tracking via symbol 
> files, I would recommend to use autopkgtests to check, that the used QML 
> modules are still fine. Start with simple "smoke" tests. aka:
> Can you execute "elisa --help"?
> Can you startup elisa by commandline without any breakage, this should test 
> the QML stuff.
> These two small tests should make sure, that most of the dependencies you need 
> are in place. 

Good idea.
I’ll do that after upload though as time is running out for buster.


Cheers,
--
Aurélien

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20190210/61efb898/attachment.sig>