Packaging review for the Elisa music player

[Pino Toscano]

In data domenica 10 febbraio 2019 11:13:37 CET, Aurélien COUDERC ha scritto:
> > - the .so symlink of the elisalib library is shipped in the binary
> > package; as the library is private, just drop the .so file -- see for
> > example the dh_auto_install override in krita
> 
> It’s fixed upstream here:
> https://phabricator.kde.org/differential/changeset/?ref=352877
> 
> So I’ll leave it like that for now and wait for the upstream change to
> reach us.

Or backport that patch, since it's easy enough.

> > - the syntax used in the dh_auto_test override (i.e. "cmd1; cmd2; cmd3")
> > basically ignores the failures of the commands, currently the fact that
> > xvfb-run is missing; one possible idea is to use a simple directory for
> > XDG_RUNTIME_DIRS like debian/tests.home, cleaning it before and after
> > the real dh_auto_test run -- see the dh_auto_test override in tellico,
> > for example
> 
> OK fixed.
> I had done that so the build would reach 100% even with some failing
> tests but it was supposed to be temporary.

There are better ways to do so:
- tell make to ignore failing commands, by prefixing "-" to a command
- ignore the failure of a specific command, eg with "|| true"

> Also I’ve added a couple of runtime dependencies to ensure it works when
> installed on top of a default Gnome install.

Please do not add libkf5mediaplayer5 as explicit dependency, as its
version will be added by shlibdeps.

> I’ll upload now as time is running out. :)

It is already too late: packages not in testing in two days will not
be allowed for buster.  Considering elisa must pass through NEW, then
this is definitely not going to happen.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20190210/a574cc97/attachment.sig>