Packaging review for the Elisa music player

[Pino Toscano]

In data lunedì 14 gennaio 2019 17:07:20 CET, Aurélien COUDERC ha scritto:
> Hi Pino,
> 
> thanks for the additional review.

Thanks for the fixes!

> If nothing more pops up I’ll push it through NEW.

I tried a build of elisa, and found more things to fix:

- the dh_auto_clean override removes .qmlc files in the sources
directory; I see none of them in the sources, are they generated at
build time, outside of the build directory? If not, then most probably
this extra work for dh_auto_clean is not needed

- the .so symlink of the elisalib library is shipped in the binary
package; as the library is private, just drop the .so file -- see for
example the dh_auto_install override in krita

- xvfb and xauth are not specified as build dependencies; without them,
the xvfb-run invocation in the dh_auto_test override does not work
(see below though)

- the syntax used in the dh_auto_test override (i.e. "cmd1; cmd2; cmd3")
basically ignores the failures of the commands, currently the fact that
xvfb-run is missing; one possible idea is to use a simple directory for
XDG_RUNTIME_DIRS like debian/tests.home, cleaning it before and after
the real dh_auto_test run -- see the dh_auto_test override in tellico,
for example

- other than xvfb and xauth, I had to add more build dependencies to
make the some of the tests work: libqt5sql5-sqlite, qml-module-qttest,
qml-module-qtqml-models2, qml-module-qtquick-layouts,
qml-module-qtquick-controls, qml-module-qtgraphicaleffects

- with all the fixes above, there are still 3 tests failing for me:
mediaplaylistTest, localfilelistingtest, elisaqmltests

- as effect of making some of the tests run, I noticed that most
probably libqt5sql5-sqlite and qml-module-qtgraphicaleffects are
missing as runtime dependencies

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20190115/54b21e8c/attachment.sig>