dh & dhmk

[Pino Toscano]

In data lunedì 4 maggio 2020 23:39:45 CEST, Sandro Knauß ha scritto:
> Hey,
> 
> In meanwhile pino also uploaded some packages that use dh. I'm completly 
> puzzled. Have we made a conclusion to switch to dh?

There's the fact that dhmk does not use dh_missing, so it becomes hard
to use when you want to switch to the debhelper compatibility 12+ and
you want to use --list-missing/--fail-missing as well (since both are
unusable with dh_install w/ compat 12+).

Also the newer binutils does already as-needed linking, which removes
another bit done.

What's left useful are:
- kde-l10n conflicts, which at least from POV will stay until the next
  stable [1]
- strict shlibs handling
and both can be hacked with a dh_gencontrol override.

[1] the majority of the kde-l10n conflicts refer to a version after
oldstable, so stable is the single stable release when these conflicts
have actually effect; considering that generally distro-updates that
skip one stable (i.e. from oldoldstable to stable) are supported
(see the tests on piuparts.d.o), I usually leave anything (breaks,
conflicts, transitional binaries, etc) for at least two stable
releases. Of course, this is my personal stance.

> > On Fri, May 01, 2020 at 09:50:53PM +0200, Sandro Knauß wrote:
> > > > * $(overridden_command), which takes care of invoking the command of
> > > > the override with all the needed parameters; while this seems trivial
> > > > to replace, imagine all the times -S/--buildsystem=kde/kf5 was
> > > > forgotten when overriding dh_auto_configure... which makes all the
> > > > Frameworks 5.41.0 in experimental :-) (thanks for proving my point)
> > 
> > The latest debhelper supports execute_before_X and execute_after_X targets,
> > which should make $(overridden_command) less useful. It will be only useful
> > when you want to pass some additional options to the overridden command.
> 
> yeah it helps a lot. Also dh-sequence-{addon} is quite nice moves stuff from 
> rules file to control.

In any case, to do this we need to add the proper provides to
pkg-kde-tools.

> But sill one very common override is dh_auto_configure. 
> @pino can you tell me what is the correct way to execute dh_auto_configure with 
> dh? 
> and how do I know, wen I have to add -S XX and when not? 
> because for dh_auto_test is it not needed right?
> where I can find those things?

From what I know, because of the way the kf5 addon works, overriding
the commands that have options added by the addon means those options
are not passed automatically anymore, so you need to do that.
The kf5 buildsystem (which is a different, but related, thing than the
kf5 addon) only does extra things on configure, so that is why you need
to pass -S/--buildsystem kf5 when overriding dh_auto_configure.
dh_auto_test with or without kf5 behaves the same, although is a (very
minor) issue. Apparently passing explicitly the kf5 buildsystem to dh
makes sure it is propagated to overriden calls, so this is why (I guess)
the dhmk conversions done at the beginning where:
%:
        dh $@ --with kf5 --buildsystem kf5 
which is a slightly redundant/mouthful IMHO. A better way would be
getting in touch with the debhelper people and ask for their input.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20200628/4e3a5df1/attachment.sig>