Make Salsa repository for libsignon+libaccounts -glib

[Aurélien COUDERC]

Le vendredi 27 mars 2020, 17:33:04 CET John Scott a écrit :
> Hello,

Dear John,

> I would like to work on a merge request for updating libsignon-glib for
> #952060 (FTBFS). It hasn't had an upload since 2015 and links point to
> anonscm.debian.org still. libaccounts-glib needs care too.

thanks for your proposal, the package and the telepathy stack in general need 
some work so your contribution is highly welcome.

Actually we do have a repo here [0] and I had been working on updating the 
package after seeing the FTBFS bug. I’ve pushed my work in a separate branch 
for now [1] as I’m not satisfied with the result yet, so feel free to commit / 
push there directly and I’ll review the changes before merging to master.  
There are a couple of contributors on #debian-qt-kde on oftc, you’re welcome 
to join us there if you like.

For uploading 1.24 the package would need to be lintian-cleaned first.
And currently the build-time tests are deactivated and I would prefer not to 
have to. They are failing on a strange post-test error in the hanling of 
background tasks with the glib stack that I’m not familiar with. I haven’t 
been able to diagnose the root cause so far, or to work around the failure as 
it doesn’t seem to impact the test assertions from libaccounts-glib itself. 
Help welcome.

task-0: check_ag.c:604:E:Store:test_store_locked_cancel:0: (after this point) 
Received signal 5 (Trace/breakpoint trap)
task-0: Exited with status 256


Also note that although the symbols didn’t change that I could notice upstream 
did bump the soname so we’ll need to upload to experimental, rebuild the rdeps 
and do a mini transition.
$ apt rdepends libaccounts-glib0 | grep -v -E "libaccounts-glib|gir1.2-
accounts"
Reverse Depends:
  Dépend: telepathy-accounts-signon (>= 1.4)
  Dépend: libaccounts-qt5-1 (>= 1.23)


For the record the FTBFS on version 1.23 currently in debian is due to :
- a glib deprecation warning and the library building with -Werror ;
- the tests failing with the same issue as 1.24 explained above.
I’m pondering uploading an 1.23-2 disabling the -Werror and the tests so the 
whole stack doesn’t go out of testing completely.


[0] https://salsa.debian.org/qt-kde-team/3rdparty/libaccounts-glib
[1] https://salsa.debian.org/qt-kde-team/3rdparty/libaccounts-glib/-/commits/
import-upstream-1.24


Happy hacking !
--
Aurélien