review kpublictransport

Hefee hefee at debian.org
Tue Apr 12 12:12:42 BST 2022


Hey,

you requested per IRC, that kpublictransport is ready for upload. There are 
some minor issues:

debian/control:
* Vcs-Fields https://salsa.debian.org/qt-kde-team/kde/kpublictransport

debian/copyright:
* please wrap to 80chars/line
* use the general license in the beginning, that is the default policy. That 
makes the copyright file more compact and easier to follow:

Files: *
Copyright: 2019, Nicolas Fella <nicolas.fella at gmx.de>
                 2018-2021, Volker Krause <vkrause at kde.org>
License: LGPL-2.0-or-later

When you release the debian/* under GPL-3+, than you need to rembember to 
specify the license of back ported patches in the debian subdir . And if you 
prepare patches to bring to upstream you also need to relicense them under 
LGPL-2+. In general I would suggest to use the same license for debian subdir 
than the project itself, but sure you are free to specify the license of your 
work!

debian/libkpublictransport1.install:
use the regex, than you do not need to update the file every time and it is 
done like everywhere else:
usr/lib/*/libKPublicTransport.so.*

debian/qml-module-org-kde-kpublictransport.install:
usr/share/qlogging-categories5/* needs to be moved to a data package ( 
kpublictransport-data) because if you only install libkpublictransport1 these 
logging-catagories need to be installed too.

debian/upstream/signing-key.asc:
This needs to be a PGP Key in amour format. You put a copied website in it ;)


Thank a lot for all you packaging work!

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20220412/6105375e/attachment.sig>


More information about the pkg-kde-talk mailing list