review kpublictransport round 3

Hefee hefee at debian.org
Fri Apr 22 10:30:14 BST 2022


Hey,

I now finshed the last bits to finally publish it to Debian and I now publish 
your work under:
https://salsa.debian.org/qt-kde-team/kde/kpublictransport

Have a look at one commit - that I had in mind when I said "with the overall 
license (*) you can remove the whole block that lists all 
the files with LGPL-2.0-or-later.":
https://salsa.debian.org/qt-kde-team/kde/kpublictransport/-/commit/
1d5ec2dbee4b17c005460349856a584f1493b8cf

I gave you Developer access, so you can push to this repo directly.

But still there are things to improve from lintian:
* symbols-file-missing-build-depends-package-field libKPublicTransport.so.1 
 - you have to specify a build-depends-package filed inside the symbols file.

* public-upstream-key-not-minimal upstream/signing-key.asc
 - the lintian descriptions tells you how to mimimize the key

* and it does not build on i386 [1], because the symbols differ. So please use 
pkgkde-symbolshelper to handle the symbols and update the symbols to match 
also i386 ( we fill find futher archs that differ, if the package gets 
accepted and builds on all archs). see https://qt-kde-team.pages.debian.net/
symbolfiles.html

[1] https://salsa.debian.org/qt-kde-team/kde/kpublictransport/-/jobs/2690364

Thanks for all your work!

hefee

PS: are you member on the pkg-kde-talk ml, than I do not need to add you 
explictly to the recipients list.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20220422/b225cdd3/attachment.sig>


More information about the pkg-kde-talk mailing list