Bug#1021364: RFS: ghostwriter/2.2.0-1 [RC] -- Distraction-free, themeable Markdown editor

[Aurélien COUDERC]

Hi Sebastian,

Le mardi 20 décembre 2022, 18:04:50 CET Sebastien Chavaux a écrit :
> Hello Aurelien :-)
> 
> For the integration of Ghostwriter in the scope of the Qt/KDE packaging
> team, I agree, no worries, I also had the case at openSUSE and I'm looking
> how I could in the following days, pass all that on to Debian as well.

thanks, I’ve moved the Salsa repo after you granted me the necessary rights.
Feel free to check that you still have access to the repo, or complain to me directly if not.

> I'll try to free up time to make the changes but it's not said. I don't
> have any Debian around right now.

That needs fixing.
Installing Debian is relatively straightforward these days, you know. ^^

Joke aside I’ve made the changes I proposed below and uploaded the package.
Thank you for working on it until now, I hope I’ll see you contributing to Debian again !


Happy hacking,
--
Aurélien


> Le mar. 20 déc. 2022 à 13:30, Aurélien COUDERC <libre at coucouf.fr> a écrit :
> 
> > To follow up on the RFS discussion:
> > - MathJax3 is currently not packaged so it’s fine to keep it vendored
> > (3rdparty) for now. We can migrate to the Debian package once it’s
> > available.
> > - The source-is-missing lintian tags are false positives to me (if lintian
> > still really emits them, I haven’t checked). The folders
> > 3rdparty/{MathJax,react} contain valid, human modifiable source files.
> > Please add a comment in the lintian-overrides file to explain so.
> > - You should use the Files-Excluded directive in debian/copyright [1] to
> > describe which files should be removed from the upstream source. That
> > should be the debian/ folder + 3rd party libraries already available in
> > Debian.
> > - I would prefer the +ds suffix instead of +dfsg, +dfsg is more
> > appropriate for cases where we remove upstream sources due to licensing
> > concerns which is not the case here IIUC.
> > - uscan --download-current-version fails, it should work from a clean
> > clone of the repo (the uupdate is not required unless I’m missing
> > something), and…
> > - it would be preferable for debian/watch to target the invent.kde.org
> > repo which is now the reference repo, you have examples for GitLab tags
> > here [2].
> > - In the git packaging repo you have the « source » folder next to the
> > « debian » folder, it should be *inside* it.
> > - source/options can be removed.
> > - Remove debian/compat and replace the debhelper (>= 11) build dependency
> > by a debhelper-compat (= 13) build dep.
> > - Remove debian/git-build-recipe.manifest ? I don’t know what it’s for so
> > it’s probably not useful. :)
> >
> >
> > Feel free to ping me or the team on IRC about any of the above.
> >
> >
> > [0] https://salsa.debian.org/qt-kde-team/extras
> > [1] https://wiki.debian.org/UscanEnhancements
> > [2] https://wiki.debian.org/debian/watch#Gitlab