review ktrip

[Hefee]

Hey,

I started to review ktrip unfortunately the copyright file has issues. The 
copyright file is VERY important part for Debian packaging ( yes I know it is a 
pain to create those copyright files and is not fun at all). So please recheck 
the copyright file. It is always good to check some files by hand, if you use 
any tools.

-> org.kde.ktrip.appdata.xml is CC0-1.0
-> several translations  (ca,ca at valencia, uk) have a special license
-> Where did you found the the overall license for those file that does not 
list an explicit license? Where do you found the GPL-3?

I also had a look at the current version 22.04 and saw, that they fixed several 
license issues for the 3rd party scripts. That's why I would suggest to not 
bother with the 21.12. (The 22.04 built successful).

KDE started to use reuse copyright information, that's why I used the reuse 
commandline tool to check (`reuse spdx` and `reuse lint`). I used decopy too, 
to check your copyright file against and than look at some files where I see 
differences... and in the end I use simple grep ( grep GPL / grep -L GPL) for 
checks...

debian/control:
* no need for adding "reuse" as build-dependency with removing reuse also the 
tests passes, as the licensecheck trest are not triggered.
* please update the description it is much too technical.

debian/watch file does not point to the tarballs
debian/upstream/signing-key.asc is not correct

debian/rules:
no need to export DEB_CFLAGS_MAINT_APPEND ( no C code in this repo)
no need to export DEB_LDFLAGS_MAINT_APPEND ( it is the default for bullseye 
tool chain).

[side note: it is always better to run the tests and make them as non failing 
instead of disabling them, this way you can check the buildlog and see the 
failing tests, that may help to track down an issue in future. This can be 
done by:
override_dh_auto_test:
	- dh_auto_test
].

regards,

hefee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20220607/f016e365/attachment.sig>