Need someone to check my code

[Hefee]

Hey,


> But it's an official sub-module for KDE systemsetting. You can
> download its tarball here: download.kde.org/kup/ So should the
> maintainer be Debian KDE Extras team or Debian Qt/KDE Maintainers?

Any software can add a sub-module for KDE systemsetting :)
Why extra? kup is not part of KDE Application or Plasma release. 

Well you still updated the debian revision in 
94f5d291c030558c6249bf337326bcf36ab06eb2
to 0.10.0-2. Please reset to 0.10.0-1.
 
> BTW, I change to my real name in the newest release.

ACK.
 
> So what to do next?

* make sure that upstream branch matches the tarball. If I run 
dpkg-buildpackage -S -d - that means those files are not the same like in the 
tarball downloaded via uscan --download-current.  You need to update the 
upstream branch with those updates and merge again to master. Either you do it 
on top or reset the branches again:

dpkg-buildpackage -S -d
[...]
dpkg-source: info: local changes detected, the modified files are:
 pkg-kup-backup/dataengine/kupservice.h
 pkg-kup-backup/dataengine/plasma-dataengine-kup.desktop
 pkg-kup-backup/filedigger/mergedvfs.cpp
 pkg-kup-backup/kcm/driveselectiondelegate.cpp
 pkg-kup-backup/kcm/kcm_kup.desktop
 pkg-kup-backup/kioslave/CMakeLists.txt
 pkg-kup-backup/kioslave/bup.protocol
 pkg-kup-backup/kioslave/bupslave.cpp
 pkg-kup-backup/kioslave/bupvfs.cpp
 pkg-kup-backup/kioslave/bupvfs.h
 pkg-kup-backup/kioslave/vfshelpers.cpp
 pkg-kup-backup/kioslave/vfshelpers.h

* Add PGP certificate to debian/upstream/signing-key.asc, so 
uscan --download-current succeed.

* Update copyright file. Also update Source line. Make sure that the copyright 
file matches the current version. Also add yourself to debian Copyrightholders.

* Bump Standards-Version to 4.7.2; check first 
/usr/share/doc/debian-policy/upgrading-checklist.txt.gz

you know lintian? lintian will properly list several issues for the package, 
that should be fixed. But before able to run lintian, we need to be able to 
build the package, that means you need to fix the first issue. 

And there is lintian-brush to help to fix several known issues. e.g. lintian-
brush --modern successfully will download the PGP key and create signing-
key.asc.

Regards,

hefee

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20250321/af96717f/attachment.sig>