Need someone to check my code

[Hefee]

Hey,

great job so far ;) This already looks very promising.

On Dienstag, 25. März 2025 04:19 Bob Wong wrote:
> Now I successfully build the package, modify cmakelists to compile it
> under QT6 while also use Debian patch system.
> 
> Do I use debian patch system correctly?

yes :)

But great that you found a way without a patch ;)
 
> If that's correct, next I'll begin to update copyright file, source
> file and also bump standards version to 4.7.2.

great - please keep Thoams  as Copyright holder for debian/* in 2017, as they 
are still copyright holder just add yourself.

Now I can build the source successfully too.
I see several linitan issues:

 * please enable hardening
add in d/rules at the top (2nd line):
export DEB_BUILD_MAINT_OPTIONS = hardening=+all

* I: kup-backup: spelling-error-in-description availibilty availability

* typo in changelog 
   - Defalult -> Default
   - trailing-whitespace [debian/changelog:11]

* unused-license-paragraph-in-dep5-copyright lgpl-2 [debian/copyright:55]
* unused-license-paragraph-in-dep5-copyright lgpl-2+ [debian/copyright:72]
* Please use lintian-brush to fix some lintian-override issues
* Add Rules-Requires-Root: no in d/control (source block)
* Create d/upstream/metadata (see https://dep-team.pages.debian.net/deps/
dep12/ and https://wiki.debian.org/UpstreamMetadata for details.)

Just a general remark - you do not need to add for every commit a line in 
changelog! If you fix stuff that was already modified in the current version you 
do not need to add a new line:

e.g. remove "Minor error correction" from changelog
also the back-and-forth ho to built Qt6 is should also be removed from 
changelog and simply write:
* Default to built with QT6 in debian/rules as suggested by Rik Mills.
* Update dependency list to use Qt6.

Regards,

hefee

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-kde-talk/attachments/20250325/debe341b/attachment.sig>