[Pkg-libburnia-devel] [Pkg-libburnia-commits] r11 - trunk/libburn/debian

[Simon Huggins]

On Mon, Feb 25, 2008 at 01:36:55AM +0000, mukidohime-guest at alioth.debian.org wrote:
> Author: mukidohime-guest
> Date: 2008-02-25 01:36:54 +0000 (Mon, 25 Feb 2008)
> New Revision: 11

> Added:
>    trunk/libburn/debian/cdrskin.manpages
>    trunk/libburn/debian/libburn-doc.install
>    trunk/libburn/debian/watch
> Removed:
>    trunk/libburn/debian/README.Debian.libburn-doc
>    trunk/libburn/debian/cdrskin.dirs
>    trunk/libburn/debian/libburn-dev.dirs
>    trunk/libburn/debian/libburn4-doc.dirs
>    trunk/libburn/debian/libburn4-doc.install
> Modified:
>    trunk/libburn/debian/changelog
>    trunk/libburn/debian/control
>    trunk/libburn/debian/copyright
>    trunk/libburn/debian/rules
> Log:
> * libburn cleanup
> * watch file

Ok, this is fairly far reaching and I'd personally prefer you discuss it
with the list first.

> +  [ Matthew Rosewarne ]
> +  * Rename libburn4-doc to libburn-doc.

This bit means it has to go through NEW again.  I can see a rationale
for both approaches.  The documentation is only useful for a particular
soname but also people who install it for one probably want it for all.

> +  * Tidy up packaging.

This isn't a very useful commit message *especially* because you've
bundled together a whole load of commits in one.

It's neater to commit little and often including changelog messages so
if someone wants to revert one bit they know what to revert or they can
reverse a merge between revisions.

> +  * Add watch file.

> Modified: trunk/libburn/debian/copyright
> ===================================================================
> --- trunk/libburn/debian/copyright	2008-02-24 12:50:17 UTC (rev 10)
> +++ trunk/libburn/debian/copyright	2008-02-25 01:36:54 UTC (rev 11)
> @@ -3,28 +3,32 @@

Mario had just checked this hadn't he?

> Deleted: trunk/libburn/debian/libburn-dev.dirs
> ===================================================================
> --- trunk/libburn/debian/libburn-dev.dirs	2008-02-24 12:50:17 UTC (rev 10)
> +++ trunk/libburn/debian/libburn-dev.dirs	2008-02-25 01:36:54 UTC (rev 11)
> @@ -1,2 +0,0 @@
> -usr/include/libburn
> -usr/lib/pkgconfig

> Added: trunk/libburn/debian/libburn-doc.install
> ===================================================================
> --- trunk/libburn/debian/libburn-doc.install	                        (rev 0)
> +++ trunk/libburn/debian/libburn-doc.install	2008-02-25 01:36:54 UTC (rev 11)
> @@ -0,0 +1,4 @@
> +doc/html/*.css usr/share/doc/libburn-doc/html/
> +doc/html/*.gif usr/share/doc/libburn-doc/html/
> +doc/html/*.html usr/share/doc/libburn-doc/html/
> +doc/html/*.png usr/share/doc/libburn-doc/html/

What are you avoiding installing?  Are these the 0 byte files?
Which changelog entry is this under?

> Modified: trunk/libburn/debian/rules
> ===================================================================
> --- trunk/libburn/debian/rules	2008-02-24 12:50:17 UTC (rev 10)
> +++ trunk/libburn/debian/rules	2008-02-25 01:36:54 UTC (rev 11)
> @@ -1,28 +1,19 @@
>  #!/usr/bin/make -f
> -# Sample debian/rules that uses cdbs.  Originaly written by Robert Millan.
> -# This file is public domain.
> -  
> -#DEB_TAR_SRCDIR                  := libburn-0.2.2
> -#DEB_AUTO_CLEANUP_RCS            := yes
> -export DH_VERBOSE=1

> -DEB_CONFIGURE_EXTRA_FLAGS := --enable-docs
> -DEB_MAKE_INSTALL_TARGET := install BUILDROOT=$(DEB_DESTDIR)
> -DEB_INSTALL_MANPAGES_cdrskin := debian/cdrskin.1
> -DEB_DH_MAKESHLIBS_ARGS_ALL := -V
> -
>  include /usr/share/cdbs/1/class/autotools.mk
> +include /usr/share/cdbs/1/rules/utils.mk
>  include /usr/share/cdbs/1/rules/debhelper.mk

> -cleanbuilddir/libburn4-doc::
> +DEB_CONFIGURE_EXTRA_FLAGS := --enable-docs
> +
> +DEB_DH_MAKESHLIBS_ARGS_ALL := -V
> +
> +cleanbuilddir/libburn-doc::
>  	rm -rf cdrskin/.libs

> -cleanbuilddir/libburn4-doc::
> +cleanbuilddir/libburn-doc::
>  	rm -rf doc/html
>  	rm -rf doc/doxygen.conf

> -build/libburn4-doc::
> +build/libburn-doc::
>  	doxygen doc/doxygen.conf
> -
> -binary-install/libburn4-doc::
> -	find debian/libburn4-doc/usr/share/doc/libburn/html/ -size 0|xargs rm

In general it's just hard to review this and I wish you'd talked to
someone first on list or on IRC.

It may well be the right thing to do though; I'm just being paranoid.

-- 
 ,--huggie-at-earth-dot-li--------stuff-thing-stuff----------DF5CE2B4--.
_|   "Peace and understanding through brute force." -- David Parsons   |_
 |                                                                     |
 `-------------------- http://www.earth.li/~huggie/ -------------------'