[Pkg-libburnia-devel] Bug#751501: libisofs: Parameter declarations of function make_isohybrid_mbr differ in signedness

[Michael Tautschnig]

Package: libisofs
Version: 1.3.2-1
Usertags: goto-cc
Tags: upstream

During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.

[...]
/bin/bash ./libtool --silent --tag=CC --mode=link gcc  -DDEBUG -g -pedantic -Wall -Wextra -Wno-unused-parameter -g -O2  -Wl,--version-script=libisofs/libisofs.ver -o libisofs/libisofs.la -rpath /usr/lib -version-info 74:0:68 libisofs/libisofs_libisofs_la-builder.lo libisofs/libisofs_libisofs_la-node.lo libisofs/libisofs_libisofs_la-tree.lo libisofs/libisofs_libisofs_la-find.lo libisofs/libisofs_libisofs_la-image.lo libisofs/libisofs_libisofs_la-fsource.lo libisofs/libisofs_libisofs_la-fs_local.lo libisofs/libisofs_libisofs_la-fs_image.lo libisofs/libisofs_libisofs_la-messages.lo libisofs/libisofs_libisofs_la-libiso_msgs.lo libisofs/libisofs_libisofs_la-stream.lo libisofs/libisofs_libisofs_la-filter.lo libisofs/filters/libisofs_libisofs_la-external.lo libisofs/filters/libisofs_libisofs_la-zisofs.lo libisofs/filters/libisofs_libisofs_la-gzip.lo libisofs/libisofs_libisofs_la-util.lo libisofs/libisofs_libisofs_la-util_rbtree.lo libisofs/libisofs_libisofs_la-util_htable.lo libisofs/libisofs_libisofs_la-filesrc.lo libisofs/libisofs_libisofs_la-ecma119.lo libisofs/libisofs_libisofs_la-ecma119_tree.lo libisofs/libisofs_libisofs_la-buffer.lo libisofs/libisofs_libisofs_la-rockridge.lo libisofs/libisofs_libisofs_la-rockridge_read.lo libisofs/libisofs_libisofs_la-joliet.lo libisofs/libisofs_libisofs_la-hfsplus.lo libisofs/libisofs_libisofs_la-hfsplus_decompose.lo libisofs/libisofs_libisofs_la-hfsplus_classes.lo libisofs/libisofs_libisofs_la-hfsplus_case.lo libisofs/libisofs_libisofs_la-eltorito.lo libisofs/libisofs_libisofs_la-system_area.lo libisofs/libisofs_libisofs_la-make_isohybrid_mbr.lo libisofs/libisofs_libisofs_la-iso1999.lo libisofs/libisofs_libisofs_la-data_source.lo libisofs/libisofs_libisofs_la-aaip_0_2.lo libisofs/libisofs_libisofs_la-md5.lo -lpthread -ljte -lz -lacl 

error: conflicting function declarations "make_isolinux_mbr"
old definition in module system_area file libisofs/system_area.c line 58
signed int (unsigned int *, struct ecma119_image *, signed int, signed int, signed int, unsigned char *, signed int)
new definition in module make_isohybrid_mbr file libisofs/make_isohybrid_mbr.c line 559
signed int (signed int *img_blocks, struct ecma119_image *t, signed int part_offset, signed int part_number, signed int fs_type, unsigned char *buf, signed int flag)
Makefile:607: recipe for target 'libisofs/libisofs.la' failed
make[1]: *** [libisofs/libisofs.la] Error 64
make[1]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-libisofs/libisofs-1.3.2'
dh_auto_test: make -j1 check returned exit code 2
debian/rules:9: recipe for target 'build' failed

Observe the difference on the pointer sub-type of the first parameter. If all
values passed around are actually positive int smaller than maximum signed int
this will be safe, but adjusting the declarations will ensure that the compiler
generates appropriate diagnostics.

Best,
Michael

PS.: I believe this is an upstream issue, but don't hold an account with
upstream's development system. If the maintainer does, please feel free to
forward. Thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 859 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-libburnia-devel/attachments/20140613/5d8bd834/attachment.sig>