[Pkg-libburnia-devel] Bug#1013313: libisoburn: Add autopkgtest

[Dominique Dumont]

On Tuesday, 21 June 2022 20:13:16 CEST Thomas Schmitt wrote:
>            case ${RET_GREP} in
>                0) # found
>                   ;;

You may want to log this case which leads to a test failure

>                1) # not found
>                  echo "${SELF}: Log file looks clear." # | tee -a ${CLOG}
> +                ok=1
>                   ;;
>               *) #
>                   echo "${SELF}: grep returned EXIT CODE: ${RET_GREP}." # |
> tee -a ${CLOG} ;;
>            esac
> +         if test "$ok" = 0 && test "$exit_value" = 0
> +         then
> +             exit_value=1
> +         fi

Fine with me

> With my sponsored packaging helper's hat on, Cc-ing Dominique Dumont
> 
> to get an opinion from under the sponsor's hat:
> > +++ libisoburn-1.5.4/debian/tests/control
> 
> I don't find this described in
>   https://www.debian.org/doc/manuals/maint-guide
> Google finds me
>   https://people.debian.org/~eriberto/README.package-tests.html

There's also https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst

This field is also supported by 'cme edit dpkg'.

> 
> > +Test-Command: cd ./releng && ./run_all_auto -x $(which xorriso)
> > +Depends: xorriso, g++, libburn-dev, libisofs-dev
> 
> At which occasion will this be run ?

This change is required to run these tests in Debian's (or Ubuntu's) CI. Since releng tests are not run when
building the package, UI guess the intent is to run releng tests every now and then.

I dont' know exactly when these Ci tests are run. I assume that Ubuntu runs them from time to time to 
check for bitrot in old packages.

An alternative is to run these tests in debian/rules so they are run at package build time.

This assumes that these tests are reliable.

> Does this have influence on the dependencies of the binary packages ?

No. Dependencies required for the tests can be declared in debian/tests/control. Without this declaration, the tests deps are
assumed to be the deps of the source package.

All the best