[Pkg-libburnia-devel] Bug#1097168: libburn: ftbfs with GCC-15

[Thomas Schmitt]

Hi,

Matthias Klose wrote:
> The package fails to build in a test rebuild on at least amd64 with
> gcc-15/g++-15, but succeeds to build with gcc-14/g++-14.
> [...]
> test/poll.c: In function ‘main’:
> test/poll.c:67:27: error: assignment to ‘__sighandler_t’ {aka ‘void
> (*)(int)’} from incompatible pointer type ‘void (*)(void)’
> [-Wincompatible-pointer-types]
>    67 |         newact.sa_handler = catch_int;
>       |                           ^
> test/poll.c:17:13: note: ‘catch_int’ declared here
>    17 | static void catch_int ()
>       |             ^~~~~~~~~
> In file included from test/poll.c:9:
> /usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
>    72 | typedef void (*__sighandler_t) (int);
>      |                ^~~~~~~~~~~~~~

This is probably resolved by a recent (yet unreleased) upstream commit:
  https://dev.lovelyhq.com/libburnia/libburn/commit/d537f9dd35282df834a311ead5f113af67d223b3
-----------------------------------------------------------------------
diff --git a/test/poll.c b/test/poll.c
index 660f384..cd5ff90 100644
--- a/test/poll.c
+++ b/test/poll.c
@@ -14,7 +14,7 @@ static struct burn_drive_info *drives;
 static unsigned int n_drives;
 int NEXT;

-static void catch_int ()
+static void catch_int (int signum)
 {
        NEXT = 1;
 }
-----------------------------------------------------------------------
caused by Daniel Pielmeier pointing me to
  https://bugs.gentoo.org/show_bug.cgi?id=943701

The affected code is not used in libburn.so.4 but rather in an obsolete
development test program.


As for the warning

> cdrskin/cdrskin.c:4464:26: warning: ‘%s’ directive writing up to 1023 bytes into a region of size 1018 [-Wformat-overflow=]
>  4464 |    sprintf(btldev,"stdio:%s",adr);

An if-test 8 lines higher verifies that strlen(adr) <= 1017.
Else the sprintf() call would prevented.


Have a nice day :)

Thomas