[Pkg-libvirt-commits] [libguestfs] 08/165: builder: Fix parallel builds of index-parse.o.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch experimental
in repository libguestfs.

commit df5bd5741b37da9cf97d7a76ac2805557aa630db
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Tue Apr 29 15:43:20 2014 +0100

    builder: Fix parallel builds of index-parse.o.
    
    When parallel builds are enabled it was possible for index-parse.c to
    be compiled before the file had been completely written by bison.  The
    usual symptom was that the 'do_parse' symbol was missing -- this
    simply happened because that symbol is defined at the end of this
    file, and the compiler compiled the file before the end part was
    written out.  But you could also see other strange & random compile
    failures as you would expect.
    
    This was tested by running this script on an 8 core server:
    
     cd builder/
     export MAKEFLAGS=-j9
     while make clean >/dev/null; make all V=1 >& /tmp/log; do echo -n . ; done
    
    Previously it would fail after <= 5 iterations.  With this change it
    runs for at least 100 iterations.
---
 builder/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builder/Makefile.am b/builder/Makefile.am
index 21710f1..0a74aa1 100644
--- a/builder/Makefile.am
+++ b/builder/Makefile.am
@@ -314,5 +314,5 @@ if HAVE_OCAML
 # index-parse.h.
 index-parser-c.c index-scan.c index-validate.c: index-parse.h
 index-parse.h: index-parse.y
-	$(MAKE) index-parse.c
+	$(MAKE) index-parse.h
 endif

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git