[Pkg-libvirt-commits] [libguestfs] 141/233: daemon: Add a note about how 'mount --rbind' doesn't work.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch experimental
in repository libguestfs.

commit d9cd2dc9b0e847fda3831c9ff13def616ca5043d
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Mon Jan 27 21:20:32 2014 +0000

    daemon: Add a note about how 'mount --rbind' doesn't work.
---
 daemon/command.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/daemon/command.c b/daemon/command.c
index 939bf87..1593de9 100644
--- a/daemon/command.c
+++ b/daemon/command.c
@@ -94,6 +94,10 @@ bind_mount (struct bind_state *bs)
     return -1;
   }
 
+  /* Note it is tempting to use --rbind here (to bind submounts).
+   * However I have not found a reliable way to unmount the same set
+   * of directories (umount -R does NOT work).
+   */
   r = command (NULL, NULL, str_mount, "--bind", "/dev", bs->sysroot_dev, NULL);
   bs->dev_ok = r != -1;
   r = command (NULL, NULL, str_mount, "--bind", "/dev/pts", bs->sysroot_dev_pts, NULL);

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git