[Pkg-libvirt-commits] [libguestfs] 18/26: appliance: init: Don't write to /proc/sys/kernel/hotplug when starting udev (RHBZ#1020806).

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag upstream/1.25.39
in repository libguestfs.

commit 7c8af234305f0fe2cb5a9042bd58fe3735e8cd73
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Thu Feb 27 12:36:13 2014 +0000

    appliance: init: Don't write to /proc/sys/kernel/hotplug when starting udev (RHBZ#1020806).
    
    /proc/sys/kernel/hotplug is an obsolete interface for processing
    hotplug events.  It is not used by modern kernels, which should set
    this path to the empty string (because they have
    CONFIG_UEVENT_HELPER_PATH="").
    
    Unfortunately our udev initialization code did:
    
      echo -e '\000\000\000\000' > /proc/sys/kernel/hotplug
    
    which was intended to set this file to \0 bytes.  However on Debian,
    where /bin/sh is "dash", not "bash", this writes "-e" to this file,
    which breaks udev events.
    
    Thanks: Peter Rajnoha for solving this.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1020806#c10
---
 appliance/init | 1 -
 1 file changed, 1 deletion(-)

diff --git a/appliance/init b/appliance/init
index c195718..76682c7 100755
--- a/appliance/init
+++ b/appliance/init
@@ -47,7 +47,6 @@ if [ -z "$UDEVD" ]; then
   echo "udev not found!  Things will probably not work ..."
 fi
 
-echo -e '\000\000\000\000' > /proc/sys/kernel/hotplug
 $UDEVD --daemon
 udevadm trigger
 udevadm settle --timeout=600

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git