[Pkg-libvirt-commits] [libguestfs] 36/59: php: fix crash with OStringList optional arguments

Hilko Bengen bengen at moszumanska.debian.org
Thu Mar 20 23:05:36 UTC 2014


This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch experimental
in repository libguestfs.

commit 083203c635d9b4c9852e46caf9135817cac3c29f
Author: Pino Toscano <ptoscano at redhat.com>
Date:   Thu Mar 13 10:24:04 2014 +0100

    php: fix crash with OStringList optional arguments
    
    Properly initialize the variables for them to NULL, so there is no crash
    because of trying to use rubbish pointers.
    
    Kind of followup of commit 289fd29f0bfbb94566d9780dd8ac3fe15e55541d.
---
 generator/php.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/generator/php.ml b/generator/php.ml
index 580b10f..c7e0a27 100644
--- a/generator/php.ml
+++ b/generator/php.ml
@@ -224,7 +224,7 @@ PHP_FUNCTION (guestfs_last_error)
               pr "  char *optargs_t_%s = NULL;\n" n;
               pr "  int optargs_t_%s_size = -1;\n" n
           | OStringList n ->
-              pr "  zval *optargs_t_%s;\n" n
+              pr "  zval *optargs_t_%s = NULL;\n" n
         ) optargs
       );
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git



More information about the Pkg-libvirt-commits mailing list