[Pkg-libvirt-commits] [libguestfs] 46/59: tests/discard: sync before close isn't necessary.

Hilko Bengen bengen at moszumanska.debian.org
Thu Mar 20 23:05:40 UTC 2014


This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch experimental
in repository libguestfs.

commit bae2134aefdfdad5c9955c69a0c9f0772c90e95e
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Fri Mar 14 13:20:22 2014 +0000

    tests/discard: sync before close isn't necessary.
    
    However we should be calling shutdown, since we're writing to the disk
    and need to catch qemu errors.
---
 tests/discard/test-discard.pl | 2 +-
 tests/discard/test-fstrim.pl  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/discard/test-discard.pl b/tests/discard/test-discard.pl
index 5e2f879..dbcf6a5 100755
--- a/tests/discard/test-discard.pl
+++ b/tests/discard/test-discard.pl
@@ -106,7 +106,7 @@ die "$0: surprising result: full size <= original size\n"
 # Remove the file and check the filesystem is trimmed automatically.
 
 $g->rm ("/data");
-$g->sync ();
+$g->shutdown ();
 $g->close ();
 
 my $trimmed_size = (stat ($disk))[12];
diff --git a/tests/discard/test-fstrim.pl b/tests/discard/test-fstrim.pl
index 30bb855..cbd28bf 100755
--- a/tests/discard/test-fstrim.pl
+++ b/tests/discard/test-fstrim.pl
@@ -114,7 +114,7 @@ die "$0: surprising result: full size <= original size\n"
 
 $g->rm ("/data");
 $g->fstrim ("/");
-$g->sync ();
+$g->shutdown ();
 $g->close ();
 
 my $trimmed_size = (stat ($disk))[12];

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git



More information about the Pkg-libvirt-commits mailing list