[Pkg-libvirt-commits] [libguestfs] 01/66: builder: Link virt-index-validate with gnulib.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch master
in repository libguestfs.

commit 5be290cd65309c48488118ca0d405459ffd946d7
Author: Olaf Hering <olaf at aepfle.de>
Date:   Fri Mar 28 10:44:16 2014 +0100

    builder: Link virt-index-validate with gnulib.
    
    [Gnulib tries to replace getopt because of the bug shown below.
    However because -lgnu was not used in the Makefile, the replacement
    failed. -- RWMJ]
    
    from config.log:
    
                 /* This code dumps core on glibc 2.14.  */
                 {
                   static char program[] = "program";
                   static char w[] = "-W";
                   static char dummy[] = "dummy";
                   char *argv[] = { program, w, dummy, NULL };
                   optind = opterr = 1;
                   if (getopt (3, argv, "W;") != 'W')
                     result |= 64;
                 }
    
    gdb --quiet --readnow ./conftest -ex r -ex bt -ex detach -ex q
    Reading symbols from /usr/src/packages/BUILD/libguestfs-1.26.0/conftest...expanding to full symbols...done.
    Starting program: /usr/src/packages/BUILD/libguestfs-1.26.0/conftest
    Missing separate debuginfo for /lib64/ld-linux-x86-64.so.2
    Try: zypper install -C "debuginfo(build-id)=5d1a12e6f0e95331cc4e39df74ecbd5adb76a1f7"
    Missing separate debuginfo for /lib64/libc.so.6
    Try: zypper install -C "debuginfo(build-id)=a06caa12df8f953a453befa827c3145adaf6269a"
    main(323) result 0
    main(344) result 0
    main(357) result 0
    main(370) result 0
    
    Program received signal SIGSEGV, Segmentation fault.
    0x00007ffff7b2dbf8 in _getopt_internal_r () from /lib64/libc.so.6
    Detaching from program: /usr/src/packages/BUILD/libguestfs-1.26.0/conftest, process 31042
    
    This change actually fixes build for me on sles11sp3 and 11.4.
    
    (cherry picked from commit effcb99f838da1c4830b4a6b0cc4394b904376f2)
---
 builder/Makefile.am | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/builder/Makefile.am b/builder/Makefile.am
index 471a53a..cf6b134 100644
--- a/builder/Makefile.am
+++ b/builder/Makefile.am
@@ -278,6 +278,9 @@ virt_index_validate_SOURCES = \
 virt_index_validate_CPPFLAGS = \
 	-DLOCALEBASEDIR=\""$(datadir)/locale"\"
 
+virt_index_validate_LDADD = \
+       -L../gnulib/lib/.libs -lgnu
+
 man_MANS += virt-index-validate.1
 noinst_DATA += $(top_builddir)/html/virt-index-validate.1.html
 

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git