[Pkg-libvirt-commits] [libguestfs] 13/66: src: Fix test-utils.c to test the validate_guid function again.

Hilko Bengen bengen at moszumanska.debian.org
Fri May 9 12:56:20 UTC 2014


This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch master
in repository libguestfs.

commit 1a144cbd42fbdcf476745962485c6535325cbe89
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Mon Mar 31 13:59:08 2014 +0100

    src: Fix test-utils.c to test the validate_guid function again.
    
    This fixes commit 768ab2e01dab5a8e7e751c33b72c1341fcaf9dc3.
    
    (cherry picked from commit 0d9a61a91ddca03fd5652441caa2a8c9123639ee)
---
 src/Makefile.am  | 4 +++-
 src/test-utils.c | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index bb4ebb3..e861467 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -249,7 +249,8 @@ libvirt_is_version_CFLAGS = \
 endif
 
 # Tests: main tests are in tests/c-api.  Here we just have some
-# internal tests of utility functions.
+# internal tests of utility functions.  Note we don't just test what's
+# in utils.c, we can test other functions as well here.
 
 TESTS_ENVIRONMENT = $(top_builddir)/run --test $(VG)
 
@@ -264,6 +265,7 @@ test_utils_CFLAGS = \
 	$(WARN_CFLAGS) $(WERROR_CFLAGS) \
 	$(GPROF_CFLAGS) $(GCOV_CFLAGS)
 test_utils_LDADD = \
+	libguestfs_la-guid.lo \
 	libutils.la \
 	$(top_builddir)/gnulib/lib/libgnu.la
 
diff --git a/src/test-utils.c b/src/test-utils.c
index 089d6b8..c4a6a62 100644
--- a/src/test-utils.c
+++ b/src/test-utils.c
@@ -16,6 +16,10 @@
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+/* This is not just a test of 'utils.c'.  We can test other internal
+ * functions here too.
+ */
+
 #include <config.h>
 
 #include <stdio.h>

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git



More information about the Pkg-libvirt-commits mailing list