[Pkg-libvirt-commits] [libguestfs] 82/179: v2v: Windows: Fix quoting and type of viostor ImagePath parameter.

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to branch experimental
in repository libguestfs.

commit 4f6033c3f4428f2c0033dfc256e71f05db17c3c2
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Fri Oct 17 17:14:52 2014 +0100

    v2v: Windows: Fix quoting and type of viostor ImagePath parameter.
    
    The way to fix these bugs -- for future reference -- is as follows:
    
    (1) Install the corresponnding Windows version with virtio enabled.
    See:
    
    https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Virtualization_Deployment_and_Administration_Guide/chap-KVM_Para_virtualized_virtio_Drivers.html
    
    (the ".vfd" method)
    
    (2) Download the SYSTEM and SOFTWARE registries from the
    virtio-enabled guest.
    
    (3) Examine each registry using 'hivexsh', especially the keys which
    we modify during virt-v2v (see v2v/convert_windows.ml).  Remember to
    use both the 'ls' and 'lsval' commands in hivexsh.
    
    (4) Download the SYSTEM and SOFTWARE registries from the guest that
    fails to boot.
    
    (5) Examine the same registry keys from each registry using 'hivexsh'.
    
    (6) Work out what the differences are, paying particular attention to
    quoting and the type of each key (eg. str(1), str(2), etc).
    
    Thanks: Matthew Booth.
---
 v2v/convert_windows.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml
index 2dbf529..9b16742 100644
--- a/v2v/convert_windows.ml
+++ b/v2v/convert_windows.ml
@@ -336,7 +336,7 @@ echo uninstalling Xen PV driver
         "Start", REG_DWORD 0x0_l;
         "Group", REG_SZ "SCSI miniport";
         "ErrorControl", REG_DWORD 0x1_l;
-        "ImagePath", REG_SZ "system32\\\\drivers\\\\viostor.sys";
+        "ImagePath", REG_EXPAND_SZ "system32\\drivers\\viostor.sys";
         "Tag", REG_DWORD 0x21_l ];
 
       [ current_cs; "Services"; "viostor"; "Parameters" ],

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git