[Pkg-libvirt-commits] [libguestfs] 01/12: Try to discourage people from using 'make install' because it causes endless support troubles.

Hilko Bengen bengen at moszumanska.debian.org
Sun Nov 1 17:11:43 UTC 2015


This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag upstream/1.29.41
in repository libguestfs.

commit 4f489b28fec699dd80615bd702d94f804a02efdd
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Thu May 7 22:19:13 2015 +0100

    Try to discourage people from using 'make install' because it causes
    endless support troubles.
---
 Makefile.am | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Makefile.am b/Makefile.am
index 580404a..b5f7eca 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -355,6 +355,21 @@ all-local:
 	find builder customize mllib resize sparsify sysprep v2v -name '*.ml' | \
 	LC_ALL=C sort > po/POTFILES-ml
 
+# Try to stop people using 'make install' without 'DESTDIR'.
+install:
+	@if test "x$(DESTDIR)" != "x" || test "x$(REALLY_INSTALL)" = "xyes"; \
+	then \
+	    $(MAKE) install-recursive; \
+	else \
+	    echo "***"; \
+	    echo "*** Using 'make install' is usually a very bad idea."; \
+	    echo "*** Use the './run' script instead - see the README."; \
+	    echo "***"; \
+	    echo "*** You can override this by setting REALLY_INSTALL=yes, but don't do that."; \
+	    echo "***"; \
+	    exit 1; \
+	fi
+
 # Manual pages in top level directory.
 
 man_MANS = \

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git



More information about the Pkg-libvirt-commits mailing list