[Pkg-libvirt-commits] [libguestfs] 04/12: builder: enable batch mode when validating non-verbose (RHBZ#1180170)

[Hilko Bengen]

This is an automated email from the git hooks/post-receive script.

bengen pushed a commit to annotated tag upstream/1.29.42
in repository libguestfs.

commit 41df8a2c4605de019a01a004a83fbad3521f5423
Author: Pino Toscano <ptoscano at redhat.com>
Date:   Mon May 11 19:12:43 2015 +0200

    builder: enable batch mode when validating non-verbose (RHBZ#1180170)
    
    When running gpg to validate a signature, use also --batch in
    non-verbose mode to avoid the extra "Good signature" messages that are
    printed by gpg2 even in quiet mode.
    We are parsing the status output anyway to check the validation result,
    so this should be harmless (and the full gpg output is printed in
    verbose mode anyway).
---
 builder/sigchecker.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builder/sigchecker.ml b/builder/sigchecker.ml
index b54977f..29f271b 100644
--- a/builder/sigchecker.ml
+++ b/builder/sigchecker.ml
@@ -159,7 +159,7 @@ and do_verify t args =
   let cmd =
     sprintf "%s --homedir %s --verify%s --status-file %s %s"
         t.gpg t.gpghome
-        (if t.verbose then "" else " -q --logger-file /dev/null")
+        (if t.verbose then "" else " --batch -q --logger-file /dev/null")
         (quote status_file) args in
   if t.verbose then printf "%s\n%!" cmd;
   let r = Sys.command cmd in

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-libvirt/libguestfs.git